Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5a1ed2afa80c4acc4434c81badc2d86b54c30f20
https://github.com/WebKit/WebKit/commit/5a1ed2afa80c4acc4434c81badc2d86b54c30f20
Author: Sam Weinig <[email protected]>
Date: 2025-01-16 (Thu, 16 Jan 2025)
Changed paths:
A LayoutTests/fast/css/font-size-calc-with-em-zoom-expected.txt
A LayoutTests/fast/css/font-size-calc-with-em-zoom.html
M Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp
Log Message:
-----------
REGRESSION (282580@main): font-size: calc(). using rem and em prevents text
from scaling up or down
https://bugs.webkit.org/show_bug.cgi?id=285914
Reviewed by Simon Fraser.
Style::computeNonCalcLengthDouble doesn't apply zoom when processing the
font-size
property, so unconditionally trying to remove zoom in the calc code path is
incorrect.
This adds a special case for font-size, which fixes the issue, but a better fix
would
be to refactor Style::computeNonCalcLengthDouble to explicitly track when zoom
is applied.
* LayoutTests/fast/css/font-size-calc-with-em-zoom-expected.txt: Added.
* LayoutTests/fast/css/font-size-calc-with-em-zoom.html: Added.
* Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp:
* Source/WebCore/style/values/primitives/StyleLengthResolution.cpp:
* Source/WebCore/style/values/primitives/StyleLengthResolution.h:
Canonical link: https://commits.webkit.org/289030@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
