Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 85541ce5e76963d994f52fcc119bb4071e73299d
https://github.com/WebKit/WebKit/commit/85541ce5e76963d994f52fcc119bb4071e73299d
Author: Alan Baradlay <[email protected]>
Date: 2025-01-16 (Thu, 16 Jan 2025)
Changed paths:
M LayoutTests/TestExpectations
A
LayoutTests/fast/multicol/out-of-flow-child-crash-with-fragments-expected.txt
A LayoutTests/fast/multicol/out-of-flow-child-crash-with-fragments.html
M Source/WebCore/rendering/RenderBlock.cpp
Log Message:
-----------
Do not set the fragmented range on a box unless the box is inside a fragment
https://bugs.webkit.org/show_bug.cgi?id=286072
Reviewed by Antti Koivisto.
When a renderer _inside_ a fragment gets destroyed, as part of the detaching
process
we remove it from the fragment range map (see
RenderFragmentedFlow::m_fragmentRangeMap).
This patch ensures that we add renderers to the map only when they claim to be
_inside_ fragments.
* LayoutTests/TestExpectations: ASSERT hits as the renderer is in an unexpected
state which this change is not meant to address.
*
LayoutTests/fast/multicol/out-of-flow-child-crash-with-fragments-expected.txt:
Added.
* LayoutTests/fast/multicol/out-of-flow-child-crash-with-fragments.html: Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeFragmentRangeForBoxChild const):
(WebCore::RenderBlock::estimateFragmentRangeForBoxChild const):
(WebCore::RenderBlock::updateFragmentRangeForBoxChild const):
Canonical link: https://commits.webkit.org/289021@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
