Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75a5507d4d8f004d43076ca036c32d4c798daccd
      
https://github.com/WebKit/WebKit/commit/75a5507d4d8f004d43076ca036c32d4c798daccd
  Author: Karl Dubost <[email protected]>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/glib/tables/mozilla/bugs/bug30332-1-expected.txt
    M LayoutTests/platform/glib/tables/mozilla/bugs/bug30332-2-expected.txt
    M LayoutTests/platform/glib/tables/mozilla/bugs/bug9879-1-expected.txt
    M 
LayoutTests/platform/glib/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/bugs/bug30332-1-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/bugs/bug30332-2-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/bugs/bug9879-1-expected.txt
    M 
LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug30332-1-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug30332-2-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug9879-1-expected.txt
    M 
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt
    M Source/WebCore/html/HTMLTableCellElement.cpp

  Log Message:
  -----------
  rowspan="0" results in different table layout than Firefox/Chrome
https://bugs.webkit.org/show_bug.cgi?id=185341
rdar://133910430

Reviewed by Alan Baradlay.

https://html.spec.whatwg.org/multipage/tables.html#attr-tdth-rowspan
> The td and th elements may also have a rowspan content attribute specified,
> whose value must be
> a valid non-negative integer less than or equal to 65534.
> For this attribute, the value zero means that the cell is
> to span all the remaining rows in the row group.

Basically is the equivalent of an imaginary all keyword.

> The rowSpan IDL attribute must reflect the rowspan content attribute.
> It is clamped to the range [0, 65534],
> and its default value is 1.

We can put the value to the maximum number of rowspan, because
it will be clamped later on for the layout to the actual number of rows.

Setting rowspan="0" is like setting a 3 or more on a table of 3 rows.

* LayoutTests/TestExpectations:
* 
LayoutTests/platform/glib/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
* LayoutTests/platform/glib/tables/mozilla/bugs/bug30332-1-expected.txt:
* LayoutTests/platform/glib/tables/mozilla/bugs/bug30332-2-expected.txt:
* LayoutTests/platform/glib/tables/mozilla/bugs/bug9879-1-expected.txt:
* 
LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
* LayoutTests/platform/ios/tables/mozilla/bugs/bug30332-1-expected.txt:
* LayoutTests/platform/ios/tables/mozilla/bugs/bug30332-2-expected.txt:
* LayoutTests/platform/ios/tables/mozilla/bugs/bug9879-1-expected.txt:
* 
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug30332-1-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug30332-2-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug9879-1-expected.txt:
* Source/WebCore/html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::rowSpan const):

Canonical link: https://commits.webkit.org/288746@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to