Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b2a0c72d97309460ae0a5d68ce78ec9f9b225c9d
https://github.com/WebKit/WebKit/commit/b2a0c72d97309460ae0a5d68ce78ec9f9b225c9d
Author: Antoine Quint <[email protected]>
Date: 2025-01-10 (Fri, 10 Jan 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-view-functional-notation.tentative-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-inset-animation-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-inset-expected.txt
M Source/WebCore/animation/ViewTimeline.cpp
Log Message:
-----------
[scroll-animations] apply view timeline insets in the correct order
https://bugs.webkit.org/show_bug.cgi?id=285697
rdar://142629948
Reviewed by Anne van Kesteren.
We had two obvious issues around our handling of view timeline insets. The
first issue is that
we never looked at the "end" inset and instead used the "start" value in both
cases. The second
issue is that we applied the "start" and "end" insets in the opposite way that
was intended: the
"start" inset needs to be applied to the end of the timeline's range, and the
"end" inset to the
start of the timeline's range. This matches the direction in which the view
timeline's subject
becomes visible.
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-view-functional-notation.tentative-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-inset-animation-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-inset-expected.txt:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::cacheCurrentTime):
(WebCore::ViewTimeline::computeTimelineData const):
Canonical link: https://commits.webkit.org/288684@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
