Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 528e93b089122e8b1a6b648835b26ce1f7d7409e
      
https://github.com/WebKit/WebKit/commit/528e93b089122e8b1a6b648835b26ce1f7d7409e
  Author: Alex Christensen <achristen...@apple.com>
  Date:   2025-01-06 (Mon, 06 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  [Site Isolation] WKWebView.underPageBackgroundColor should only be updated 
from the main frame layer transaction
https://bugs.webkit.org/show_bug.cgi?id=285477
rdar://142440682

Reviewed by Simon Fraser.

In 283227@main I fixed a flicker of the Safari UI color by making 
WKWebView.themeColor
only updated from the main frame process.  I still saw a similar flicker 
occasionally,
and I finally investigated a page that had it and found that Safari doesn't 
only use
WKWebView.themeColor, but also WKWebView.underPageBackgroundColor.  This 
applies the
same fix to all the page color change updates from the layer transaction and 
appends
to the test in a way that used to show the source of the flicker.

* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::didCommitLayerTree):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, ThemeColor)):

Canonical link: https://commits.webkit.org/288491@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to