[webkit-changes] [WebKit/WebKit] efdea8: ep.gov.pk: is hidden behind
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: efdea8f207ac164a766fb45bf4ffa4a6bcf7b330
      
https://github.com/WebKit/WebKit/commit/efdea8f207ac164a766fb45bf4ffa4a6bcf7b330
  Author: Alan Baradlay <za...@apple.com>
  Date:   2025-01-06 (Mon, 06 Jan 2025)

  Changed paths:
    A LayoutTests/fast/block/float/marquee-shrink-to-avoid-floats-expected.html
    M LayoutTests/fast/block/float/marquee-shrink-to-avoid-floats.html
    R 
LayoutTests/platform/glib/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt
    R 
LayoutTests/platform/ios/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt
    R 
LayoutTests/platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.png
    R 
LayoutTests/platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt
    R 
LayoutTests/platform/win/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  ep.gov.pk: <marquee> is hidden behind <div>
https://bugs.webkit.org/show_bug.cgi?id=281325

Reviewed by Antti Koivisto.

Marquee's shrinking behavior changed in 20632@main to fix a regression (see 
webkit.org/b/15296) but this behavior does seem non-interoperable anymore.
Both Firefox and Chrome disagree with WebKit here and they don't shrink the 
width of the inline marquee.
Confusingly the comment above this line (which was added _after_ the behavior 
change) suggests that marquees do _not_ shrink (and yet they do).

Let's revert to prior 20632@main and don't let inline marquees shrink when 
adjacent to float(s).

* LayoutTests/fast/block/float/marquee-shrink-to-avoid-floats-expected.html: 
Added.
* LayoutTests/fast/block/float/marquee-shrink-to-avoid-floats.html:
* 
LayoutTests/platform/glib/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
 Removed.
* 
LayoutTests/platform/ios/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
 Removed.
* 
LayoutTests/platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.png:
 Removed.
* 
LayoutTests/platform/mac/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
 Removed.
* 
LayoutTests/platform/win/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
 Removed.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::shrinkToAvoidFloats const):

Canonical link: https://commits.webkit.org/288461@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to