Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 96920369569d88a98d395fc19038f1de3f6f8914
https://github.com/WebKit/WebKit/commit/96920369569d88a98d395fc19038f1de3f6f8914
Author: Kimmo Kinnunen <[email protected]>
Date: 2025-01-03 (Fri, 03 Jan 2025)
Changed paths:
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.h
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.h
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
Remove unneeded ENABLE_UNIFIED_PDF_SELECTION_LAYER
https://bugs.webkit.org/show_bug.cgi?id=285294
rdar://142257942
Reviewed by Abrar Rahman Protyasha.
Remove the define, it was rendered obsolete by
[UnifiedPDF] Drop support for painting selections into the contents layer #38280
288199@main, 2c6aaf8
Fixes issues where the code is written as if the selection layer would
be optional, when in fact after 288199@main it is not.
Remove HAVE_PDFSELECTION_ENUMERATE_RECTS_AND_TRANSFORMS. Instead, just
check for the selector dynamically in case UnifiedPDF is enabled on
platforms that do not actually support it.
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h:
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.h:
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm:
(WebKit::PDFDiscretePresentationController::buildRows):
(WebKit::PDFDiscretePresentationController::updateLayersOnLayoutChange):
(WebKit::PDFDiscretePresentationController::updateLayersAfterChangeInVisibleRow):
(WebKit::PDFDiscretePresentationController::updateIsInWindow):
(WebKit::PDFDiscretePresentationController::updateDebugBorders):
(WebKit::PDFDiscretePresentationController::repaintForIncrementalLoad):
(WebKit::PDFDiscretePresentationController::setNeedsRepaintInDocumentRect):
(WebKit::PDFDiscretePresentationController::paintContents):
(WebKit::PDFDiscretePresentationController::paintPDFSelection):
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.h:
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm:
(WebKit::PDFScrollingPresentationController::teardown):
(WebKit::PDFScrollingPresentationController::setupLayers):
(WebKit::PDFScrollingPresentationController::updateLayersOnLayoutChange):
(WebKit::PDFScrollingPresentationController::updateIsInWindow):
(WebKit::PDFScrollingPresentationController::updateDebugBorders):
(WebKit::PDFScrollingPresentationController::setNeedsRepaintInDocumentRect):
(WebKit::PDFScrollingPresentationController::paintContents):
(WebKit::PDFScrollingPresentationController::paintPDFSelection):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paintPDFSelection):
(WebKit::UnifiedPDFPlugin::platformPopulateEditorStateIfNeeded const):
(WebKit::UnifiedPDFPlugin::cursorContext const): Deleted.
(WebKit::UnifiedPDFPlugin::documentEditingContext const): Deleted.
(WebKit::UnifiedPDFPlugin::pageToRootView const): Deleted.
(WebKit::UnifiedPDFPlugin::rootViewToPage const): Deleted.
Canonical link: https://commits.webkit.org/288397@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
