Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5e8aa3294f74adc9adc3d99cc5c2724e6bd86ba
      
https://github.com/WebKit/WebKit/commit/f5e8aa3294f74adc9adc3d99cc5c2724e6bd86ba
  Author: Lily Spiniolas <[email protected]>
  Date:   2024-12-18 (Wed, 18 Dec 2024)

  Changed paths:
    M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
    A Source/WebCore/PAL/pal/spi/cocoa/NSStepperCellSPI.h
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm
    M Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.h
    M Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.mm
    M Source/WebCore/platform/mac/ThemeMac.mm

  Log Message:
  -----------
  Use NSStepperCell to draw spin buttons rather than CoreUI
https://bugs.webkit.org/show_bug.cgi?id=284655
rdar://140298961

Reviewed by Aditya Keerthi.

NSStepperCell is now used to draw spin buttons when its property
'incrementing' is available. When the property is unavailable,
the original CoreUI implementation is used instead.

* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebCore/PAL/pal/spi/cocoa/NSStepperCellSPI.h: Added.
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm:
(WebCore::ControlFactoryMac::stepperCell const):
(WebCore::ControlFactoryMac::createPlatformInnerSpinButton):
* Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.h:
* Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.mm:
(WebCore::InnerSpinButtonMac::InnerSpinButtonMac):
(WebCore::InnerSpinButtonMac::cellSize const):
(WebCore::InnerSpinButtonMac::draw):
(WebCore::InnerSpinButtonMac::drawWithCell):
(WebCore::InnerSpinButtonMac::drawWithCoreUI):
(WebCore::InnerSpinButtonMac::rectForBounds const):
(WebCore::InnerSpinButtonMac::updateCellStates):
* Source/WebCore/platform/mac/ThemeMac.mm:
(WebCore::stepperSizes):

Canonical link: https://commits.webkit.org/288070@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to