Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c89abf514d7dc4445ccf652175a61263edd647fb
      
https://github.com/WebKit/WebKit/commit/c89abf514d7dc4445ccf652175a61263edd647fb
  Author: Gerald Squelart <g_squel...@apple.com>
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
    A LayoutTests/fast/forms/range/range-set-value-repaint-expected.html
    A LayoutTests/fast/forms/range/range-set-value-repaint.html
    M Source/WebCore/html/shadow/SliderThumbElement.cpp

  Log Message:
  -----------
  Correctly repaint <input type=range> track after setValue
https://bugs.webkit.org/show_bug.cgi?id=284773
rdar://138049784

Reviewed by Alan Baradlay.

When the input was set to a specific value, internally the
thumb was moved to the correct position, which marked as
dirty both areas for the previous and new positions.
However, nothing else was marked dirty, including the track
itself, so if the thumb moved from (say) 0% to 100%, some
of the middle part may not have been marked as dirty.
On iOS, the track has a different color on each side of
the thumb position, so the non-dirty part was staying the
same color as it was before.

The fix is to ensure that the track gets repainted, so that
any needed color change happens along its length.

* LayoutTests/fast/forms/range/range-set-value-repaint-expected.html: Added.
* LayoutTests/fast/forms/range/range-set-value-repaint.html: Added.
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout):

Canonical link: https://commits.webkit.org/287976@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to