Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0a51f6550adadbf4b0adec0f920de9649b2c0cdb
https://github.com/WebKit/WebKit/commit/0a51f6550adadbf4b0adec0f920de9649b2c0cdb
Author: Wenson Hsieh <[email protected]>
Date: 2024-12-14 (Sat, 14 Dec 2024)
Changed paths:
M Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm
Log Message:
-----------
[iOS 18]
TestWebKitAPI.KeyboardInputTests.EditableWebViewRequiresKeyboardWhenFirstResponder
is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=284578
rdar://141397449
Reviewed by Aditya Keerthi.
The first step in this API test (which currently fails) verifies that when a
hardware keyboard is
not attached, `-_requiresKeyboardWhenFirstResponder` returns `NO` on the
content view. Prior to
iOS 18.1, UIKit used `-[UIKeyboardImpl hardwareKeyboardAttached]` to determine
if there's a hardware
keyboard attached, and used that to determine if the keyboard should appear
automatically when the
web view is the first responder.
However, after iOS 18.1, UIKit now uses `+[UIKeyboard
isInHardwareKeyboardMode]`. Account for this
in the API test by swizzling this method as well.
* Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
(TestWebKitAPI::TEST(KeyboardInputTests,
EditableWebViewRequiresKeyboardWhenFirstResponder)):
(TestWebKitAPI::overrideHardwareKeyboardAttached): Deleted.
(TestWebKitAPI::TEST(KeyboardInputTests,
DISABLED_EditableWebViewRequiresKeyboardWhenFirstResponder)): Deleted.
Canonical link: https://commits.webkit.org/287846@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
