Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 11f3d0601ecc98aa0b9879e63a5f655ef472326b
https://github.com/WebKit/WebKit/commit/11f3d0601ecc98aa0b9879e63a5f655ef472326b
Author: Youenn Fablet <you...@apple.com>
Date: 2024-12-08 (Sun, 08 Dec 2024)
Changed paths:
M
LayoutTests/http/tests/workers/service/resources/shownotification-worker.js
M LayoutTests/http/tests/workers/service/shownotification-allowed.html
M LayoutTests/platform/mac-wk2/TestExpectations
Log Message:
-----------
REGRESSION(286686@main?): [macOS]
http/tests/workers/service/shownotification-allowed.html is a constant failure
(flaky in EWS)
rdar://140875944
https://bugs.webkit.org/show_bug.cgi?id=283999
Reviewed by Chris Dumez.
http/tests/workers/service/shownotification-allowed.html was failing as we were:
- stopping the service worker due to network process crash
- recreating the service worker, but in a different process from the web page
- sending a message to the web page via self.clients
- But the web page is not reregistering it as a service worker client since it
does not create a new connection to the network process.
To fix this, we make sure the web page recreates a connection to the network
process and we make sure the service worker loops until it can send the message
to at least one client.
* LayoutTests/http/tests/workers/service/resources/shownotification-worker.js:
(let.messageClients):
* LayoutTests/http/tests/workers/service/shownotification-allowed.html:
* LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/287520@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
