Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d78f8ae748e3103d954fcf113a4496a5385f2853
https://github.com/WebKit/WebKit/commit/d78f8ae748e3103d954fcf113a4496a5385f2853
Author: Jessica Lee <[email protected]>
Date: 2024-12-07 (Sat, 07 Dec 2024)
Changed paths:
M LayoutTests/js/dom/webidl-type-mapping-expected.txt
M LayoutTests/js/dom/webidl-type-mapping.html
M Source/WebCore/bindings/js/JSDOMConvertRecord.h
Log Message:
-----------
JSC::JSValue convert of JSConverter<IDLRecord<K, V>> crashes when converting
an input WebCore::IDLRecord<WebCore::IDLUSVString,
WebCore::IDLUnion<WebCore::IDLUndefined, WebCore::IDLUSVString>>
https://bugs.webkit.org/show_bug.cgi?id=284132
rdar://141017497
Reviewed by Chris Dumez and Sihui Liu.
According to spec https://webidl.spec.whatwg.org/#js-record, we should use
<bool createDataProperty(JSGlobalObject*, PropertyName, JSValue, bool
shouldThrow)> to convert a native object to a IDL Record, not putDirect which
is what's currently implemented and incorrectly assumes that the input property
name is not an index.
* LayoutTests/js/dom/webidl-type-mapping-expected.txt:
* LayoutTests/js/dom/webidl-type-mapping.html:
* Source/WebCore/bindings/js/JSDOMConvertRecord.h:
Canonical link: https://commits.webkit.org/287506@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
