Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 765a88e45dd99c0f8502a3cd13a5a583a5f9fcc5
https://github.com/WebKit/WebKit/commit/765a88e45dd99c0f8502a3cd13a5a583a5f9fcc5
Author: Mike Wyrzykowski <[email protected]>
Date: 2024-12-06 (Fri, 06 Dec 2024)
Changed paths:
A LayoutTests/fast/webgpu/nocrash/fuzz-284093-expected.txt
A LayoutTests/fast/webgpu/nocrash/fuzz-284093.html
M Source/WebGPU/WebGPU/BindGroup.mm
M Source/WebGPU/WebGPU/CommandBuffer.h
M Source/WebGPU/WebGPU/CommandBuffer.mm
M Source/WebGPU/WebGPU/CommandEncoder.mm
Log Message:
-----------
[WebGPU] CommandEncoder should be retained until its associated CommandBuffer
completes
https://bugs.webkit.org/show_bug.cgi?id=284093
rdar://140802957
Reviewed by Tadeu Zagallo.
Buffers, Textures, and ExternalTextures maintain references to their
associated CommandEncoder to know when the GPU has completed a workload.
However, this means we need to keep the CommandEncoder alive until its
associated CommandBuffer becomes invalid or completes execution.
* LayoutTests/fast/webgpu/nocrash/fuzz-284093-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-284093.html: Added.
Add regression test.
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::BindGroup::updateExternalTextures):
* Source/WebGPU/WebGPU/CommandBuffer.h:
(WebGPU::CommandBuffer::create):
* Source/WebGPU/WebGPU/CommandBuffer.mm:
(WebGPU::CommandBuffer::CommandBuffer):
(WebGPU::CommandBuffer::makeInvalid):
(WebGPU::CommandBuffer::makeInvalidDueToCommit):
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::finish):
Canonical link: https://commits.webkit.org/287497@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
