Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8066e3f9f8716c5184a9bfa11d7e7a25b28aa372
https://github.com/WebKit/WebKit/commit/8066e3f9f8716c5184a9bfa11d7e7a25b28aa372
Author: Sammy Gill <sammy.g...@apple.com>
Date: 2024-12-04 (Wed, 04 Dec 2024)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/computedstyle/block-level-replaced-elements-affected-by-block-step-size-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/computedstyle/block-level-replaced-elements-affected-by-block-step-size.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/computedstyle/inline-level-replaced-elements-not-affected-by-block-step-size-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/computedstyle/inline-level-replaced-elements-not-affected-by-block-step-size.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-canvas-margins-affected-by-block-step-size-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-canvas-margins-affected-by-block-step-size.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-embed-margins-affected-by-block-step-size-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-embed-margins-affected-by-block-step-size.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-iframe-margins-affected-by-block-step-size-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-iframe-margins-affected-by-block-step-size.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-img-margins-affected-by-block-step-size-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-img-margins-affected-by-block-step-size.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-object-margins-affected-by-block-step-size-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-object-margins-affected-by-block-step-size.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-svg-margins-affected-by-block-step-size-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-svg-margins-affected-by-block-step-size.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-video-margins-affected-by-block-step-size-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-video-margins-affected-by-block-step-size.html
Log Message:
-----------
[block-step-sizing] Add some tests to verify interaction between
block-step-size and margins of various replaced elements.
https://bugs.webkit.org/show_bug.cgi?id=284060
rdar://140931188
Reviewed by Alan Baradlay.
block-step-size should be able to adjust the margins of block-level
replaced elements appropriately while not affecting inline-level ones at
all. This patch adds some tests to help verify this behavior.
The block-level-* tests make sure that the extra space is added to the
margins of various block-level replaced elements.
A corresponding test was also added in
css-rhythm/computedstyle/block-level-replaced-elements-affected-by-block-step-size.html
to make sure getComputedStyle returns the correct value for the adjusted
margins. This test basically contains the added tests in
css-rhythm/replaced-elements but checks the value of the box's margins
and the height of the container via getComputedStyle. Some of the tests
subtests are failing even though the box is sized correctly as seen
in the equivalent ref test that was added. This will need to be
investigated, but one theory is that this could be the same underlying
bug as http://webkit.org/b/283508.
css-rhythm/computedstyle/inline-level-replaced-elements-not-affected-by-block-step-size.html
is the counterpart to the above test to make sure that replaced elements
which are inline do not get affected by the property at all.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/computedstyle/block-level-replaced-elements-affected-by-block-step-size-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/computedstyle/block-level-replaced-elements-affected-by-block-step-size.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/computedstyle/inline-level-replaced-elements-not-affected-by-block-step-size-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/computedstyle/inline-level-replaced-elements-not-affected-by-block-step-size.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-canvas-margins-affected-by-block-step-size-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-canvas-margins-affected-by-block-step-size.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-embed-margins-affected-by-block-step-size-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-embed-margins-affected-by-block-step-size.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-iframe-margins-affected-by-block-step-size-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-iframe-margins-affected-by-block-step-size.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-img-margins-affected-by-block-step-size-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-img-margins-affected-by-block-step-size.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-object-margins-affected-by-block-step-size-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-object-margins-affected-by-block-step-size.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-svg-margins-affected-by-block-step-size-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-svg-margins-affected-by-block-step-size.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-video-margins-affected-by-block-step-size-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-rhythm/replaced-elements/block-level-video-margins-affected-by-block-step-size.html:
Added.
Canonical link: https://commits.webkit.org/287379@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
