Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 99271c3ed9de09126848bc18c277da8144c2b07e
https://github.com/WebKit/WebKit/commit/99271c3ed9de09126848bc18c277da8144c2b07e
Author: Richard Robinson <[email protected]>
Date: 2024-12-02 (Mon, 02 Dec 2024)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/FullscreenClient.h
Log Message:
-----------
[iOS] Entering full screen may not work in web views even when
`isElementFullscreenEnabled` is enabled
https://bugs.webkit.org/show_bug.cgi?id=283853
rdar://138336212
Reviewed by Wenson Hsieh.
The bit-field bool values in the `m_delegateMethods` struct in
`FullscreenClient.h` are not guaranteed to be
initialized to `false`. As a result, if there is no fullscreen delegate, these
values are undefined.
Particularly in the case of `webViewRequestPresentingViewController` being
`true`, this causes entering fullscreen
to fail, since the completion handler in
`FullscreenClient::requestPresentingViewController` won't actually ever
be invoked.
Fix by default-initializing all the bit-field values in this class to `false`.
* Source/WebKit/UIProcess/Cocoa/FullscreenClient.h:
Canonical link: https://commits.webkit.org/287216@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
