Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 35b3fc5d9015f3b089d0aa090b07ed7840c666f8
https://github.com/WebKit/WebKit/commit/35b3fc5d9015f3b089d0aa090b07ed7840c666f8
Author: Wenson Hsieh <wenson_hs...@apple.com>
Date: 2024-11-28 (Thu, 28 Nov 2024)
Changed paths:
A
LayoutTests/fast/scrolling/mac/no-keyboard-scrolling-when-holding-shift-expected.txt
A
LayoutTests/fast/scrolling/mac/no-keyboard-scrolling-when-holding-shift.html
M Source/WebCore/platform/KeyboardScrollingAnimator.cpp
Log Message:
-----------
[macOS] Pressing Shift + Up should not cause the page to scroll
https://bugs.webkit.org/show_bug.cgi?id=283806
rdar://137983379
Reviewed by Richard Robinson.
Currently, pressing Shift + Up (or Shift + Alt|Command + Up) triggers keyboard
scrolling; this
behavior is inconsistent with Firefox and Chrome on macOS, as well as Safari on
iPadOS. This also
leads to unintuitive behaviors after pressing Shift + Up to modify the
selection, since keyboard
scrolling will immediately start once the selection is collapsed.
Fix this by returning early in the case where the shift key is held, when
pressing up or down on the
keyboard.
*
LayoutTests/fast/scrolling/mac/no-keyboard-scrolling-when-holding-shift-expected.txt:
Added.
* LayoutTests/fast/scrolling/mac/no-keyboard-scrolling-when-holding-shift.html:
Added.
* Source/WebCore/platform/KeyboardScrollingAnimator.cpp:
(WebCore::scrollGranularityForKeyboardEvent):
Canonical link: https://commits.webkit.org/287161@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
