Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ea352280424fe1276451efb0a27c03e7c70a57e
https://github.com/WebKit/WebKit/commit/5ea352280424fe1276451efb0a27c03e7c70a57e
Author: Vitaly Dyachkov <vit...@igalia.com>
Date: 2024-11-28 (Thu, 28 Nov 2024)
Changed paths:
M LayoutTests/fast/canvas/webgl/canvas-test.html
Log Message:
-----------
REGRESSION(286103@main): [Debug]
`fast/canvas/webgl/canvas-webgl-page-cache.html` is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=283554
Reviewed by Anne van Kesteren.
`fast/canvas/webgl/canvas-webgl-page-cache.html` is wrongly accused.
The actual culprit is `fast/canvas/webgl/canvas-test.html` but it
crashes after reporting a failure and confusing the test runner.
Results history [1] proves this by showing that the pattern of
`canvas-webgl-page-cache.html` crashes absolutely matches the pattern of
`canvas-test.html` failures.
286103@main made `testRunner.displayAndTrackRepaints()` asynchronous. In
`canvas-test.html`, it's being called from `setInterval()`'s callback
before `clearInterval()`. That can lead to a situation where the
callback is triggered again while the first execution is waiting for
`displayAndTrackRepaints()` to be resolved.
Results of failing test runs [2] prove that by showing logs reported by
the callback multiple times.
This patch fixes the test by moving `displayAndTrackRepaints()` out of
the callback. This requires wrapping the test logic into an `async`
function.
Also, similarly to 157930@main, finishing the test was simplified by
calling `finishTest()` from `webgl-test.js`. This should speed it up.
1.
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=fast%2Fcanvas%2Fwebgl%2Fcanvas-test.html&test=fast%2Fcanvas%2Fwebgl%2Fcanvas-webgl-page-cache.html&style=debug&limit=5000
2.
https://build.webkit.org/results/GTK-Linux-64-bit-Debug-Tests/287141@main%20(14983)/fast/canvas/webgl/canvas-test-actual.txt
* LayoutTests/fast/canvas/webgl/canvas-test.html:
Canonical link: https://commits.webkit.org/287155@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
