Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28de6f13360ba8af5bbc08c2ed35f8ec0ded94a9
      
https://github.com/WebKit/WebKit/commit/28de6f13360ba8af5bbc08c2ed35f8ec0ded94a9
  Author: Carlos Alberto Lopez Perez <clo...@igalia.com>
  Date:   2024-11-28 (Thu, 28 Nov 2024)

  Changed paths:
    M 
Tools/Scripts/webkitpy/binary_bundling/tests/webdriver/test_webdriver_bundle.py

  Log Message:
  -----------
  [Tools][GTK][WPE] generate-bundle test suite: retry tests before marking them 
as a failure to avoid flaky/network issues
https://bugs.webkit.org/show_bug.cgi?id=283764

Reviewed by Carlos Garcia Campos.

On the WPE and GTK Nightly packaging bots we run a test step with WebDriver
and the generated bundle to ensure that the MiniBrowser bundle works.

The problem is that this step is randomly failing. I suspect is related
with the network as some tests require loading resources from internet
(videos, ssl certs, wasm files, etc)

So to make the test step more robust retry each one of the webdriver tests
up to 3 times (by default) before marking it as a failure.

This should be ok, becasue the intention of this step is to detect when the
generated bundle is broken and in that case it should fail all the 3 times
that the test is retried.

* 
Tools/Scripts/webkitpy/binary_bundling/tests/webdriver/test_webdriver_bundle.py:
(WebDriverTests.__init__):
(WebDriverTests.do_test):
(run_all_tests):
(main):

Canonical link: https://commits.webkit.org/287150@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to