Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c077ba3cb140797d981cd48e3c37f4e55e9efcaf
https://github.com/WebKit/WebKit/commit/c077ba3cb140797d981cd48e3c37f4e55e9efcaf
Author: Jean-Yves Avenard <j...@apple.com>
Date: 2024-11-27 (Wed, 27 Nov 2024)
Changed paths:
M LayoutTests/media/media-sources-selection.html
M LayoutTests/platform/mac-wk1/TestExpectations
M
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt
R
LayoutTests/platform/mac/imported/w3c/web-platform-tests/media-source/SourceBuffer-abort-updating-expected.txt
R
LayoutTests/platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-invalid-codec-expected.txt
M PerformanceTests/DecoderTest/DecoderTest/main.mm
M Source/ThirdParty/libwebrtc/CMakeLists.txt
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
R
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitDecoderReceiver.cpp
R
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitDecoderReceiver.h
R
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitVP8Decoder.cpp
R
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitVP8Decoder.h
R
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitVP9Decoder.cpp
R
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitVP9Decoder.h
M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/platform/VideoDecoder.cpp
M Source/WebCore/platform/VideoDecoder.h
M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
M Source/WebCore/platform/audio/PlatformMediaSessionManager.h
M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
M Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.h
M Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm
M Source/WebCore/platform/graphics/cocoa/VideoMediaSampleRenderer.mm
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp
M Source/WebKit/GPUProcess/GPUProcess.cpp
M Source/WebKit/GPUProcess/GPUProcess.h
M Source/WebKit/GPUProcess/GPUProcessPreferences.cpp
M Source/WebKit/GPUProcess/GPUProcessPreferences.h
M Source/WebKit/GPUProcess/GPUProcessPreferences.serialization.in
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
Remove VideoToolbox VP8 and VP9 plugins
https://bugs.webkit.org/show_bug.cgi?id=282163
rdar://138751645
Reviewed by Youenn Fablet.
The VideoToolbox VP8 and VP plugins were only usable on Macs and were
non-functional on other platforms which
use mediaserverd.
We can streamline the code path and use the WebCodecs' VideoDecoder code path
on all platforms; doing so make
the VideoToolbox plugins dead-code.
While we had a preference to disable the VP8 settings, it was in effect
non-functional on WK2 as we would always default
to the VideoDecoder if the VideoToolbox was disabled. So we can remove this
setting altogether considering the time
we have shipped with an always enabled VP8 decoder.
We remove the settings. A side effect is that it will now enable VP8 on WK1
however considering:
- We reduce the number of diverging code path.
- WK1 had support for WebM with Vorbis and Opus, just not VP8.
This made WebM in a semi-broken state as VP8 is the most common codec found
with this container
it's an acceptable compromise.
Covered by existing tests.
* LayoutTests/media/media-sources-selection.html:
* LayoutTests/platform/mac-wk1/TestExpectations: Re-enable MSE tests with webm
using vp8 videos.
*
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt:
vp8 is now supported, update expectation.
*
LayoutTests/platform/mac/imported/w3c/web-platform-tests/media-source/SourceBuffer-abort-updating-expected.txt:
Removed.
*
LayoutTests/platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-invalid-codec-expected.txt:
Removed.
* PerformanceTests/DecoderTest/DecoderTest/main.mm:
(main):
* Source/ThirdParty/libwebrtc/CMakeLists.txt:
* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
*
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitDecoderReceiver.cpp:
Removed.
*
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitDecoderReceiver.h:
Removed.
*
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitVP8Decoder.cpp:
Removed.
*
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitVP8Decoder.h:
Removed.
*
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitVP9Decoder.cpp:
Removed.
*
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/WebKit/WebKitVP9Decoder.h:
Removed.
* Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/platform/VideoDecoder.cpp:
(WebCore::VideoDecoder::isVPXSupported):
* Source/WebCore/platform/VideoDecoder.h:
* Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::setShouldEnableVP8Decoder): Deleted.
(WebCore::PlatformMediaSessionManager::shouldEnableVP8Decoder): Deleted.
* Source/WebCore/platform/audio/PlatformMediaSessionManager.h:
* Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::ensureCodecsRegistered):
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::seekInternal): Fly-By: no need to flush the
tracks again, as we just flushed everything earlier.
* Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.h:
* Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
(WebCore::isVP9DecoderAvailable):
(WebCore::isVP8DecoderAvailable):
(WebCore::registerWebKitVP9Decoder): Deleted.
(WebCore::registerWebKitVP8Decoder): Deleted.
* Source/WebCore/platform/graphics/cocoa/VideoMediaSampleRenderer.mm:
(WebCore::VideoMediaSampleRenderer::enqueueSample):
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::registerWebKitVP9Decoder): Deleted.
(WebCore::LibWebRTCProvider::registerWebKitVP8Decoder): Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
(WebCore::LibWebRTCProvider::registerWebKitVP9Decoder): Deleted.
(WebCore::LibWebRTCProvider::registerWebKitVP8Decoder): Deleted.
* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::updateGPUProcessPreferences):
* Source/WebKit/GPUProcess/GPUProcess.h:
* Source/WebKit/GPUProcess/GPUProcessPreferences.cpp:
(WebKit::GPUProcessPreferences::copyEnabledWebPreferences):
* Source/WebKit/GPUProcess/GPUProcessPreferences.h:
* Source/WebKit/GPUProcess/GPUProcessPreferences.serialization.in:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):
Canonical link: https://commits.webkit.org/287137@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
