Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6027c342f898dd4eb0cb8a013aea6832da007318 https://github.com/WebKit/WebKit/commit/6027c342f898dd4eb0cb8a013aea6832da007318 Author: Devin Rousso <h...@devinrousso.com> Date: 2024-11-27 (Wed, 27 Nov 2024)
Changed paths: M Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.css M Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js Log Message: ----------- Web Inspector: Graphics: Recording: WebGL objects are not highlighted correctly https://bugs.webkit.org/show_bug.cgi?id=283736 Reviewed by Tim Nguyen. * Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js: (WI.RecordingActionTreeElement): (WI.RecordingActionTreeElement._generateDOM): (WI.RecordingActionTreeElement._generateDOM.createParameterElement): (WI.RecordingActionTreeElement.prototype.populateContextMenu): (WI.RecordingActionTreeElement.prototype.customTitleTooltip): Deleted. Give the paremeter type text the same styling as the object handle by having both be text in the same element. As such, we no longer need to generate and save the text that would be copied since it exactly matches what's shown. * Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.css: (.item.recording-action > .titles .context-replacer::after): Deleted. (.item.recording-action.attribute > .titles .parameters::before): Deleted. (.item.recording-action:not(.attribute) > .titles .parameters::before): Deleted. (.item.recording-action:not(.attribute) > .titles .parameters::after): Deleted. (.item.recording-action > .titles .parameter:not(:last-child)::after): Deleted. There is a bug in `Source/JavaScriptCore/Scripts/cssmin.py` that will cause `content: ", "` to be transformed into `content: ","`. Instead, just move the text content into the DOM where it should be anyways. This also helps with the above. Canonical link: https://commits.webkit.org/287127@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes