Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7197bea01b904080885ed9c6dfe92b2511f61ac1
https://github.com/WebKit/WebKit/commit/7197bea01b904080885ed9c6dfe92b2511f61ac1
Author: Vitaly Dyachkov <[email protected]>
Date: 2024-11-21 (Thu, 21 Nov 2024)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/fast/ruby/ruby-text-before-child-split-expected.txt
M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.h
M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderInline.h
M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp
Log Message:
-----------
[Ruby][Continuation] InsertionPosition's parent and nextSibling (beforeChild)
are in different subtrees
https://bugs.webkit.org/show_bug.cgi?id=276007
Reviewed by Antti Koivisto.
When looking for the parent of a <ruby> child renderer
we should check continuation chain to make sure that it belongs
to the same render subtree as `beforeChild`.
The algorithms are already implemented as static `continuationBefore()`
functions
in `RenderTreeBuilder:Block` and `RenderTreeBuilder::Inline` classes.
This patch makes them public static class methods and then uses them to
find the right parent.
* LayoutTests/TestExpectations:
* LayoutTests/fast/ruby/ruby-text-before-child-split-expected.txt:
* Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:
(WebCore::RenderTreeBuilder::Block::continuationBefore):
(WebCore::continuationBefore): Deleted.
* Source/WebCore/rendering/updating/RenderTreeBuilderBlock.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::RenderTreeBuilder::Inline::continuationBefore):
(WebCore::cloneAsContinuation):
(WebCore::continuationBefore): Deleted.
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForStyleBasedRubyChild):
Canonical link: https://commits.webkit.org/286902@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
