Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 70aa17d691291485bf20f7ad7deebc58a2eb02e6
https://github.com/WebKit/WebKit/commit/70aa17d691291485bf20f7ad7deebc58a2eb02e6
Author: Alan Baradlay <za...@apple.com>
Date: 2024-11-14 (Thu, 14 Nov 2024)
Changed paths:
M
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/TextBoxPainter.cpp
M Source/WebCore/rendering/TextBoxPainter.h
Log Message:
-----------
[TextBoxPainter] Let's use the cached RenderStyle consistently
https://bugs.webkit.org/show_bug.cgi?id=282561
Reviewed by Antti Koivisto.
1. Line dependent style is what TextBox has. No need to check for isFirstLine.
2. Pass in the relevant style (this is in preparation for using TextBoxPainter
across visually adjacent text boxes).
3. Adjust RenderText::styleDidChange to work with block container style change
too
(imported/w3c/web-platform-tests/css/css-conditional/container-queries/pseudo-elements-002b.html
fails when first line style changes due to block container width change)
*
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:
(WebCore::LayoutIntegration::InlineContentPainter::paintDisplayBox):
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::TextBoxPainter):
(WebCore::TextBoxPainter::paintCompositionForeground):
(WebCore::TextBoxPainter::paintForegroundAndDecorations):
(WebCore::TextBoxPainter::collectDecoratingBoxesForTextBox):
(WebCore::TextBoxPainter::paintForegroundDecorations):
(WebCore::TextBoxPainter::fillCompositionUnderline const):
(WebCore::TextBoxPainter::fontCascade const):
(WebCore::TextBoxPainter::textOriginFromPaintRect const):
* Source/WebCore/rendering/TextBoxPainter.h:
Canonical link: https://commits.webkit.org/286627@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
