Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 33507394bab520401cc6904e737ec053229e98eb https://github.com/WebKit/WebKit/commit/33507394bab520401cc6904e737ec053229e98eb Author: Matthieu Dubet <m_du...@apple.com> Date: 2024-11-14 (Thu, 14 Nov 2024)
Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-descendant-003-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-descendant-003.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-002-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-002.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-003-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-003.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-004-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-004.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-005-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-005.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-006-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-006.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-not-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-not-001.html M Source/WebCore/css/SelectorChecker.cpp Log Message: ----------- [CSS] Don't combine :not() with :host https://bugs.webkit.org/show_bug.cgi?id=282960 rdar://139198548 Reviewed by Tim Nguyen. As a featureless element, only :host matches the shadow host. Functional pseudoclasses pass the behavior to their arguments, so :is(:host) matches the same as :host (the shadow host). This fixes a regression introduced in 281963@main. Before 281963, :host combination with a functional pseudoclass (or anything but a pseudo-element more generally) was early returning "not match". 281963 has removed the early return for all functional pseudoclass (to allow :is() combined with :host, but also :not()). Properly supporting :host combining with :not() is tricky and will be handled in a followup patch. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-descendant-003-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-descendant-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-003-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-004-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-004.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-005-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-005.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-006-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-multiple-006.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-not-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-not-001.html: Added. * Source/WebCore/css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOne const): Canonical link: https://commits.webkit.org/286611@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes