Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ee545145e8f9cfc60843070c17626ad7c6b13b36 https://github.com/WebKit/WebKit/commit/ee545145e8f9cfc60843070c17626ad7c6b13b36 Author: Elika Etemad <fantasai.b...@inkedblade.net> Date: 2024-11-14 (Thu, 14 Nov 2024)
Changed paths: M Source/WebCore/rendering/FlexibleBoxAlgorithm.cpp M Source/WebCore/rendering/GridBaselineAlignment.cpp M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/RenderBlock.h M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBox.h M Source/WebCore/rendering/RenderBoxModelObject.h M Source/WebCore/rendering/RenderFlexibleBox.cpp M Source/WebCore/rendering/RenderGrid.cpp M Source/WebCore/rendering/RenderInline.cpp M Source/WebCore/rendering/RenderInline.h M Source/WebCore/rendering/RenderLineBreak.h M Source/WebCore/rendering/RenderTableCell.cpp M Source/WebCore/rendering/RenderTableCell.h M Source/WebCore/rendering/RenderTableCellInlines.h M Source/WebCore/rendering/RenderTableCol.cpp M Source/WebCore/rendering/RenderTableRow.cpp M Source/WebCore/rendering/RenderTableRowInlines.h M Source/WebCore/rendering/RenderTableSection.cpp M Source/WebCore/rendering/RenderTableSectionInlines.h M Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h Log Message: ----------- Switch margin/border/padding to use WritingMode arg instead of RenderStyle https://bugs.webkit.org/show_bug.cgi?id=282719 rdar://problem/139386989 Reviewed by Alan Baradlay. Consistently and directly use an optional WritingMode object as the argument for logical margin/border/padding getters and setters, for more readable and adaptable code. * Source/WebCore/rendering/FlexibleBoxAlgorithm.cpp: (WebCore::FlexLayoutAlgorithm::removeMarginEndFromFlexSizes const): * Source/WebCore/rendering/GridBaselineAlignment.cpp: (WebCore::GridBaselineAlignment::ascentForGridItem const): * Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithm::setup): * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::marginIntrinsicLogicalWidthForChild const): (WebCore::RenderBlock::computeBlockPreferredLogicalWidths const): (WebCore::RenderBlock::computePreferredWidthsForExcludedChildren const): * Source/WebCore/rendering/RenderBlock.h: (WebCore::RenderBlock::marginBeforeForChild const): (WebCore::RenderBlock::marginAfterForChild const): (WebCore::RenderBlock::marginStartForChild const): (WebCore::RenderBlock::marginEndForChild const): (WebCore::RenderBlock::setMarginStartForChild const): (WebCore::RenderBlock::setMarginEndForChild const): (WebCore::RenderBlock::setMarginBeforeForChild const): (WebCore::RenderBlock::setMarginAfterForChild const): * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::determineLogicalLeftPositionForChild): (WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::computeInlineDirectionMargins const): (WebCore::RenderBox::constrainBlockMarginInAvailableSpaceOrTrim const): * Source/WebCore/rendering/RenderBox.h: (WebCore::RenderBox::marginLogicalLeft const): (WebCore::RenderBox::marginLogicalRight const): (WebCore::RenderBox::marginBefore const): (WebCore::RenderBox::marginAfter const): (WebCore::RenderBox::marginStart const): (WebCore::RenderBox::marginEnd const): (WebCore::RenderBox::setMarginBefore): (WebCore::RenderBox::setMarginAfter): (WebCore::RenderBox::setMarginStart): (WebCore::RenderBox::setMarginEnd): (WebCore::RenderBox::marginBlockStart const): Deleted. (WebCore::RenderBox::marginInlineStart const): Deleted. * Source/WebCore/rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::marginBefore const): (WebCore::RenderBoxModelObject::marginAfter const): (WebCore::RenderBoxModelObject::marginStart const): (WebCore::RenderBoxModelObject::marginEnd const): * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::trimMainAxisMarginStart): (WebCore::RenderFlexibleBox::trimMainAxisMarginEnd): * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::updateAutoMarginsInRowAxisIfNeeded): (WebCore::RenderGrid::updateAutoMarginsInColumnAxisIfNeeded): (WebCore::RenderGrid::logicalOffsetForOutOfFlowGridItem const): * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::marginStart const): (WebCore::RenderInline::marginEnd const): (WebCore::RenderInline::marginBefore const): (WebCore::RenderInline::marginAfter const): * Source/WebCore/rendering/RenderInline.h: (WebCore::RenderInline::marginBefore const): (WebCore::RenderInline::marginAfter const): (WebCore::RenderInline::marginStart const): (WebCore::RenderInline::marginEnd const): * Source/WebCore/rendering/RenderLineBreak.h: * Source/WebCore/rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::localRectsForRepaint const): (WebCore::RenderTableCell::computeCollapsedStartBorder const): (WebCore::RenderTableCell::computeCollapsedEndBorder const): (WebCore::RenderTableCell::computeCollapsedBeforeBorder const): (WebCore::RenderTableCell::computeCollapsedAfterBorder const): (WebCore::RenderTableCell::borderHalfLeft const): (WebCore::RenderTableCell::borderHalfRight const): (WebCore::RenderTableCell::borderHalfTop const): (WebCore::RenderTableCell::borderHalfBottom const): (WebCore::RenderTableCell::borderHalfStart const): (WebCore::RenderTableCell::borderHalfEnd const): (WebCore::RenderTableCell::borderHalfBefore const): (WebCore::RenderTableCell::borderHalfAfter const): (WebCore::RenderTableCell::paintCollapsedBorders): * Source/WebCore/rendering/RenderTableCell.h: * Source/WebCore/rendering/RenderTableCellInlines.h: (WebCore::RenderTableCell::borderAdjoiningCellAfter): (WebCore::RenderTableCell::borderAdjoiningCellBefore): (WebCore::RenderTableCell::borderAdjoiningTableEnd const): (WebCore::RenderTableCell::borderAdjoiningTableStart const): * Source/WebCore/rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::borderAdjoiningCellStartBorder const): (WebCore::RenderTableCol::borderAdjoiningCellEndBorder const): (WebCore::RenderTableCol::borderAdjoiningCellBefore const): (WebCore::RenderTableCol::borderAdjoiningCellAfter const): * Source/WebCore/rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::borderAdjoiningStartCell const): (WebCore::RenderTableRow::borderAdjoiningEndCell const): * Source/WebCore/rendering/RenderTableRowInlines.h: (WebCore::RenderTableRow::borderAdjoiningTableStart const): (WebCore::RenderTableRow::borderAdjoiningTableEnd const): * Source/WebCore/rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcOuterBorderBefore const): (WebCore::RenderTableSection::calcOuterBorderAfter const): (WebCore::RenderTableSection::calcOuterBorderStart const): (WebCore::RenderTableSection::calcOuterBorderEnd const): (WebCore::RenderTableSection::borderAdjoiningStartCell const): (WebCore::RenderTableSection::borderAdjoiningEndCell const): * Source/WebCore/rendering/RenderTableSectionInlines.h: (WebCore::RenderTableSection::borderAdjoiningTableEnd const): (WebCore::RenderTableSection::borderAdjoiningTableStart const): * Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp: (WebCore::logicalTopOffset): (WebCore::logicalLeftOffset): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::borderBefore const): (WebCore::RenderStyle::borderAfter const): (WebCore::RenderStyle::borderStart const): (WebCore::RenderStyle::borderEnd const): (WebCore::RenderStyle::borderBeforeWidth const): (WebCore::RenderStyle::borderAfterWidth const): (WebCore::RenderStyle::borderStartWidth const): (WebCore::RenderStyle::borderEndWidth const): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::border const): (WebCore::RenderStyle::borderBottomWidth const): (WebCore::RenderStyle::borderRightWidth const): (WebCore::RenderStyle::logicalHeight const): (WebCore::RenderStyle::logicalMaxHeight const): (WebCore::RenderStyle::logicalMaxWidth const): (WebCore::RenderStyle::logicalMinHeight const): (WebCore::RenderStyle::logicalMinWidth const): (WebCore::RenderStyle::logicalWidth const): (WebCore::RenderStyle::marginBox const): (WebCore::RenderStyle::marginAfter const): (WebCore::RenderStyle::marginBefore const): (WebCore::RenderStyle::marginEnd const): (WebCore::RenderStyle::marginStart const): (WebCore::RenderStyle::paddingAfter const): (WebCore::RenderStyle::paddingBefore const): (WebCore::RenderStyle::paddingEnd const): (WebCore::RenderStyle::paddingStart const): (WebCore::RenderStyle::borderAfter const): Deleted. (WebCore::RenderStyle::borderBefore const): Deleted. (WebCore::RenderStyle::borderEnd const): Deleted. (WebCore::RenderStyle::borderStart const): Deleted. (WebCore::RenderStyle::marginAfterUsing const): Deleted. (WebCore::RenderStyle::marginBeforeUsing const): Deleted. (WebCore::RenderStyle::marginEndUsing const): Deleted. (WebCore::RenderStyle::marginStartUsing const): Deleted. Canonical link: https://commits.webkit.org/286604@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes