Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 67c6b7bfcb72ef186c8a9468fecc16b29e1561b1
https://github.com/WebKit/WebKit/commit/67c6b7bfcb72ef186c8a9468fecc16b29e1561b1
Author: Yusuke Suzuki <ysuz...@apple.com>
Date: 2024-11-14 (Thu, 14 Nov 2024)
Changed paths:
M Source/JavaScriptCore/runtime/Structure.cpp
M Source/JavaScriptCore/runtime/Structure.h
Log Message:
-----------
[JSC] Remove / AttributeChange should follow to what Structure Add chaining
suppression is doing
https://bugs.webkit.org/show_bug.cgi?id=283094
rdar://138491533
Reviewed by Yijia Huang.
There is possibility that structure's properties are already super large (due to
initial capacity), and copying the table causes troubles for memory
consumption and time. This patch adds some guard similar to what we are
doing for Structure add transition to avoid the issue. We pick 4096
based on the currently running benchmarks.
* Source/JavaScriptCore/runtime/Structure.cpp:
(JSC::Structure::removeNewPropertyTransition):
(JSC::Structure::attributeChangeTransition):
* Source/JavaScriptCore/runtime/Structure.h:
(JSC::Structure::shouldDoCacheableDictionaryTransitionForRemoveAndAttributeChange):
(JSC::Structure::transitionCountHasOverflowed const): Deleted.
Canonical link: https://commits.webkit.org/286601@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
