Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f2554a7bf3fafaf732e9ea2f5584ffa1a8a6616f
https://github.com/WebKit/WebKit/commit/f2554a7bf3fafaf732e9ea2f5584ffa1a8a6616f
Author: Gerald Squelart <g_squel...@apple.com>
Date: 2024-11-12 (Tue, 12 Nov 2024)
Changed paths:
M Source/WTF/wtf/text/Base64.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.h
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
M Source/WebKit/Shared/ColorControlSupportsAlpha.h
M Tools/Scripts/webkitpy/style/checkers/cpp.py
M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Log Message:
-----------
Enforce enum : bool { No, Yes } order
https://bugs.webkit.org/show_bug.cgi?id=282674
rdar://problem/139335415
Reviewed by Anne van Kesteren.
This ensures that casting to/from the underlying bool matches
the expected values No==0==false and Yes==1==true.
check-webkit-style now catches unexpected {Yes,No} ordering.
A few instances were caught and fixed.
* Source/WTF/wtf/text/Base64.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.cpp:
* Source/WebCore/dom/Document.h:
* Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.h:
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
* Source/WebKit/Shared/ColorControlSupportsAlpha.h:
* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(_EnumState.__init__):
(_EnumState.process_clean_line):
(_EnumState.process_clean_line.check_case_error):
(_EnumState.process_clean_line.check_case_error.is_case_error):
(_EnumState.process_clean_line.check_member_list):
(_EnumState):
(check_enum_members):
(check_style):
(CppChecker):
(_EnumState.process_clean_line.is_case_error): Deleted.
(check_enum_casing): Deleted.
* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(NoNonVirtualDestructorsTest):
Canonical link: https://commits.webkit.org/286492@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
