Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 74fba0c2cf751f120626c3505c2a895032f6635d
https://github.com/WebKit/WebKit/commit/74fba0c2cf751f120626c3505c2a895032f6635d
Author: Yusuke Suzuki <ysuz...@apple.com>
Date: 2024-11-10 (Sun, 10 Nov 2024)
Changed paths:
M Source/JavaScriptCore/API/JSContext.mm
Log Message:
-----------
REGRESSION(284791@main): [ Debug ] 2x
TestWebKitAPI.JavaScriptCore.Incremental* (api-tests) are constant asserts
https://bugs.webkit.org/show_bug.cgi?id=281074
rdar://137526107
Reviewed by Keith Miller.
We should avoid using Strong<> in JSContext. The initialization of
Strong<> will happen before JSContext's init code runs, and this means
that we will hit Strong<> initialization before initializing VM. Let's
just use RetainPtr<JSValue> so that we do not need to run the above
code. Using RetainPtr<JSValue> is also natural because this m_exception
is JSValue property.
* Source/JavaScriptCore/API/JSContext.mm:
(-[JSContext dealloc]):
(-[JSContext setException:]):
(-[JSContext exception]):
Canonical link: https://commits.webkit.org/286414@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
