Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fc2f523dcf1795c36b78db355c44d3923df9bb8d
https://github.com/WebKit/WebKit/commit/fc2f523dcf1795c36b78db355c44d3923df9bb8d
Author: Jamie <he...@itsjamie.dev>
Date: 2024-11-09 (Sat, 09 Nov 2024)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
M Source/WebKit/UIProcess/Extensions/WebExtension.h
Log Message:
-----------
Port WebExtension Actions to C++
https://webkit.org/b/282859
Reviewed by Timothy Hatcher.
Following up from the icon work, port the rest of the Web Extension actions to
C++, and remove the redundant actionObjects created throughout
WebExtension.cpp
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm:
(-[WKWebExtension displayActionLabel]):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(WebKit::WebExtensionAction::label const):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::displayActionLabel): Deleted.
(WebKit::WebExtension::actionPopupPath): Deleted.
(WebKit::WebExtension::hasAction): Deleted.
(WebKit::WebExtension::hasBrowserAction): Deleted.
(WebKit::WebExtension::hasPageAction): Deleted.
(WebKit::WebExtension::populateActionPropertiesIfNeeded): Deleted.
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp:
(WebKit::WebExtension::createError):
(WebKit::WebExtension::populateActionPropertiesIfNeeded):
(WebKit::WebExtension::displayActionLabel):
(WebKit::WebExtension::actionPopupPath):
(WebKit::WebExtension::hasAction):
(WebKit::WebExtension::hasBrowserAction):
(WebKit::WebExtension::hasPageAction):
(WebKit::WebExtension::actionIcon):
* Source/WebKit/UIProcess/Extensions/WebExtension.h:
Canonical link: https://commits.webkit.org/286380@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
