Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6feab009ebad1069533f590b16f2b167c5b012f0 https://github.com/WebKit/WebKit/commit/6feab009ebad1069533f590b16f2b167c5b012f0 Author: Geoffrey Garen <gga...@apple.com> Date: 2024-11-07 (Thu, 07 Nov 2024)
Changed paths: M Source/JavaScriptCore/Configurations/Base.xcconfig M Source/JavaScriptCore/assembler/MacroAssembler.h M Source/JavaScriptCore/assembler/testmasm.cpp M Source/JavaScriptCore/b3/air/opcode_generator.rb M Source/JavaScriptCore/b3/air/testair.cpp M Source/JavaScriptCore/b3/testb3_1.cpp M Source/JavaScriptCore/b3/testb3_2.cpp M Source/JavaScriptCore/b3/testb3_3.cpp M Source/JavaScriptCore/b3/testb3_4.cpp M Source/JavaScriptCore/b3/testb3_5.cpp M Source/JavaScriptCore/b3/testb3_6.cpp M Source/JavaScriptCore/b3/testb3_7.cpp M Source/JavaScriptCore/b3/testb3_8.cpp M Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/jit/GPRInfo.h M Source/JavaScriptCore/jit/JITCodeMap.h M Source/JavaScriptCore/jit/JITOperations.cpp M Source/JavaScriptCore/jit/SIMDShuffle.h M Source/JavaScriptCore/runtime/JSCell.cpp M Source/JavaScriptCore/runtime/Uint16WithFraction.h M Source/JavaScriptCore/tools/HeapVerifier.cpp M Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp M Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.h M Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp M Source/JavaScriptCore/wasm/generateWasmOpsHeader.py M Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.cpp M Source/JavaScriptCore/yarr/YarrJIT.cpp M Source/WTF/wtf/ButterflyArray.h M Source/WTF/wtf/FixedBitVector.h M Source/WTF/wtf/Liveness.h M Source/WTF/wtf/text/StringSearch.h M Source/WebCore/Configurations/Base.xcconfig M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp M Source/WebCore/Modules/mediastream/SFrameUtils.cpp M Source/WebCore/Modules/mediastream/SFrameUtils.h M Source/WebCore/Modules/mediastream/STUNMessageParsing.cpp M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp M Source/WebCore/Modules/webauthn/AuthenticatorAttestationResponse.cpp M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp M Source/WebCore/cssjit/RegisterAllocator.h M Source/WebCore/fileapi/Blob.cpp M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm M Source/WebCore/platform/audio/mac/AudioSessionMac.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/rendering/mac/RenderThemeMac.mm M Source/WebCore/style/RuleSet.cpp Log Message: ----------- Added some missing cases of WTF_ALLOW_UNSAFE_BUFFER_USAGE https://bugs.webkit.org/show_bug.cgi?id=282775 rdar://139463652 Reviewed by David Kilzer. We had one header that #ifdef'd the closing WTF_ALLOW_UNSAFE_BUFFER_USAGE_END incorrectly, which, in unified builds, had the effect of skipping unsafe buffer usage warnings in subsequent files. I fixed the closing WTF_ALLOW_UNSAFE_BUFFER_USAGE_END, and then added WTF_ALLOW_UNSAFE_BUFFER_USAGE_END annotations to all the new files that showed up as failures. I'm also temporarily disabling WTF_ALLOW_UNSAFE_BUFFER_USAGE enforcement in JSC and WebCore to ensure I get pre-commit and post-commit bot results before re-enabling. (I left WebKit enabled because I don't want to regress on our 100% coverage achievement, and the header was in JSC and I didn't find any new failures in WebKit.) * Source/JavaScriptCore/assembler/MacroAssembler.h: * Source/JavaScriptCore/assembler/testmasm.cpp: * Source/JavaScriptCore/b3/air/opcode_generator.rb: * Source/JavaScriptCore/b3/air/testair.cpp: * Source/JavaScriptCore/b3/testb3_1.cpp: * Source/JavaScriptCore/b3/testb3_2.cpp: * Source/JavaScriptCore/b3/testb3_3.cpp: * Source/JavaScriptCore/b3/testb3_4.cpp: * Source/JavaScriptCore/b3/testb3_5.cpp: * Source/JavaScriptCore/b3/testb3_6.cpp: * Source/JavaScriptCore/b3/testb3_7.cpp: * Source/JavaScriptCore/b3/testb3_8.cpp: * Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp: * Source/JavaScriptCore/jit/SIMDShuffle.h: * Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp: * Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.h: * Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp: * Source/JavaScriptCore/wasm/WasmSlowPaths.cpp: * Source/JavaScriptCore/wasm/generateWasmOpsHeader.py: * Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.cpp: * Source/WTF/wtf/ButterflyArray.h: * Source/WTF/wtf/FixedBitVector.h: * Source/WTF/wtf/Liveness.h: * Source/WTF/wtf/text/StringSearch.h: * Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp: * Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp: * Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp: * Source/WebCore/Modules/mediastream/SFrameUtils.cpp: * Source/WebCore/Modules/mediastream/SFrameUtils.h: * Source/WebCore/Modules/mediastream/STUNMessageParsing.cpp: * Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp: * Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp: * Source/WebCore/Modules/webauthn/AuthenticatorAttestationResponse.cpp: * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: * Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp: * Source/WebCore/cssjit/RegisterAllocator.h: * Source/WebCore/fileapi/Blob.cpp: * Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm: * Source/WebCore/platform/audio/mac/AudioSessionMac.mm: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: * Source/WebCore/rendering/mac/RenderThemeMac.mm: Canonical link: https://commits.webkit.org/286318@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes