Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6115517674045ec83c36c570bf353e30718d5499
https://github.com/WebKit/WebKit/commit/6115517674045ec83c36c570bf353e30718d5499
Author: Nikolaos Mouchtaris <[email protected]>
Date: 2024-11-02 (Sat, 02 Nov 2024)
Changed paths:
A
LayoutTests/fast/scrolling/mac/scrollbars/scrollbar-width-dynamic-none-to-auto-expected.html
A
LayoutTests/fast/scrolling/mac/scrollbars/scrollbar-width-dynamic-none-to-auto.html
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/page/scrolling/mac/ScrollerMac.h
M Source/WebCore/page/scrolling/mac/ScrollerMac.mm
M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm
Log Message:
-----------
Dynamically switching from scrollbar-width:none to scrollbar-width:auto/thin
doesn't bring back scrollbar
https://bugs.webkit.org/show_bug.cgi?id=282419
rdar://139040042
Reviewed by Simon Fraser.
Previously, scrollbar-width:none was implemented by nulling out the host layer
on the
NSScrollerImp. When switching from scrollbar-width:none to
scrollbar-width:auto/thin,
we wouldn't keep around the old scrollbar layer, which would cause the
scrollbar to not
appear. We fix this by implementing scrollbar-width:none as nulling out the
NSScrollerImp
when hidden by style, and keeping around the previous scrollbar layer on
m_hostLayer to
be re-attached when switching back to scrollbar-width:auto/thin.
* Source/WebCore/page/scrolling/mac/ScrollerMac.h:
* Source/WebCore/page/scrolling/mac/ScrollerMac.mm:
(WebCore::ScrollerMac::setHiddenByStyle):
(WebCore::ScrollerMac::updateScrollbarStyle):
(WebCore::ScrollerMac::updatePairScrollerImps):
(WebCore::ScrollerMac::updateMinimumKnobLength):
* Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
(WebCore::ScrollingTreeScrollingNodeDelegateMac::updateFromStateNode):
Canonical link: https://commits.webkit.org/286057@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
