Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0bbbd26aee6010a09afb73db99aad5603a98a6fa
https://github.com/WebKit/WebKit/commit/0bbbd26aee6010a09afb73db99aad5603a98a6fa
Author: Jessica Cheung <jcheun...@apple.com>
Date: 2024-10-30 (Wed, 30 Oct 2024)
Changed paths:
A
LayoutTests/editing/selection/ios/hide-selection-in-hidden-container-noneditable-expected.txt
A
LayoutTests/editing/selection/ios/hide-selection-in-hidden-container-noneditable.html
M Source/WebCore/dom/Position.h
M Source/WebKit/Shared/EditorState.h
M Source/WebKit/Shared/EditorState.serialization.in
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
Log Message:
-----------
icloud.com: duplicate and strangely offset highlight in icloud.com notes
https://bugs.webkit.org/show_bug.cgi?id=282102
rdar://137094713
Reviewed by Wenson Hsieh.
icloud.com renders their own selection in their style so we should
hide our real selection UI. However, we display our selection as well
in addition to icloud.com notes which results in the strange duplicate offset
selection being shown.
We should change the logic of supressing selection to include
if selection container element is clipped/transparent instead of just if the
editable root element is clipped/transparent.
In this example, when we are not editing, the duplicate selection is shown.
Finally, added a LayoutTest to confirm this new behavior works as intended by
selecting
something noneditable in a hidden container.
*
LayoutTests/editing/selection/ios/hide-selection-in-hidden-container-noneditable-expected.txt:
Added.
*
LayoutTests/editing/selection/ios/hide-selection-in-hidden-container-noneditable.html:
Added.
* Source/WebCore/dom/Position.h:
* Source/WebKit/Shared/EditorState.h:
* Source/WebKit/Shared/EditorState.serialization.in:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _updateSelectionAssistantSuppressionState]):
(-[WKContentView hasHiddenContentEditable]):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::updateCursorAccessoryPlacement):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::isTransparentOrFullyClipped const):
(WebKit::WebPage::getPlatformEditorStateCommon const):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
Canonical link: https://commits.webkit.org/285925@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
