Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d5b59e631ddf6182d5dc21b4eb10c9530c07889a https://github.com/WebKit/WebKit/commit/d5b59e631ddf6182d5dc21b4eb10c9530c07889a Author: Elliott Williams <e...@apple.com> Date: 2024-10-23 (Wed, 23 Oct 2024)
Changed paths: A Tools/WebKitTestRunner/Scripts/install-extensions-rule.sh M Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj M Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/xcshareddata/xcschemes/WebKitTestRunner.xcscheme Log Message: ----------- WebKitTestRunner: Code sign app extensions as they are copied https://bugs.webkit.org/show_bug.cgi?id=281930 rdar://problem/138437628 Reviewed by Alexey Proskuryakov and Per Arne Vollan. Using WebKitTestRunnerApp on device requires app extensions to have a code signature that aligns with their containing application. We already transform our extensions' bundle IDs when they are copied into WebKitTestRunnerApp.app/Extensions. Now, re-sign them during the copy. Xcode has a "CodeSignOnCopy" attribute, but it doesn't do anything for files copied via a custom build rule. It does, however, appear to indicate to the build system that the containing bundle needs to be re-signed when the extensions change. As drive-by refactors, add WebKitTestRunnerApp to the "All" aggregate target, so that `make -C Tools/WebKitTestRunner` builds the app on iOS. Also move the "Install Extensions" build rule into its own file, since it has become quite large for an inline script. * Tools/WebKitTestRunner/Scripts/install-extensions-rule.sh: Added. * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/xcshareddata/xcschemes/WebKitTestRunner.xcscheme: Canonical link: https://commits.webkit.org/285611@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes