Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e367a94d5ace381debe2045be82380cd4cac13c2 https://github.com/WebKit/WebKit/commit/e367a94d5ace381debe2045be82380cd4cac13c2 Author: Antoine Quint <grao...@webkit.org> Date: 2024-10-17 (Thu, 17 Oct 2024)
Changed paths: M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-named-scroll-progress-timeline.tentative-expected.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/JSAnimationTimelineCustom.cpp Log Message: ----------- [scroll-animations] make `Animation.timeline` return `ScrollTimeline` and `ViewTimeline` instances https://bugs.webkit.org/show_bug.cgi?id=281684 rdar://138135049 Reviewed by Chris Dumez and Anne van Kesteren. Getting the `timeline` property of a style-originated animation associated with a progress-based timeline returns an `AnimationTimeline` instance instead of either `ScrollTimeline` or `ViewTimeline`. We now return the right wrapper based on the various `AnimationTimeline` subclasses and ensure we don't ever return an `AnimationTimeline` itself with an assertion. * LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-named-scroll-progress-timeline.tentative-expected.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/JSAnimationTimelineCustom.cpp: (WebCore::toJSNewlyCreated): Canonical link: https://commits.webkit.org/285377@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes