Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5397a7b48c6861b1ec5f655de6975dd56e11ebc5 https://github.com/WebKit/WebKit/commit/5397a7b48c6861b1ec5f655de6975dd56e11ebc5 Author: Georges Basile Stavracas Neto <feane...@igalia.com> Date: 2024-10-17 (Thu, 17 Oct 2024)
Changed paths: M Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp Log Message: ----------- AX: [GTK]: Fix crash in AccessibilityObjectAtspi::textAttributes https://bugs.webkit.org/show_bug.cgi?id=281492 Reviewed by Carlos Garcia Campos. In the AccessibilityObjectAtspi::textAttributes() method, the accessibilityTextAttributes() function is called for various AXObjects. These objects are retrived by querying the AXObjectCache of the document. However, the cache can legitimately return nullptr when the AXObject is not cached. The AccessibilityObjectAtspi::textAttributes() method did not check for nullptr, and the accessibilityTextAttributes() function is not nullptr safe. This crashes. Make AccessibilityObjectAtspi::textAttributes() check if the AXObject is a nullptr before passing it down to accessibilityTextAttributes(). * Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp: (WebCore::AccessibilityObjectAtspi::textAttributes const): Canonical link: https://commits.webkit.org/285325@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes