Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: aab43ebf7ddb84015830dad9f4f4c6e310a88aea
https://github.com/WebKit/WebKit/commit/aab43ebf7ddb84015830dad9f4f4c6e310a88aea
Author: Philippe Normand <ph...@igalia.com>
Date: 2024-09-25 (Wed, 25 Sep 2024)
Changed paths:
M
Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp
M
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp
Log Message:
-----------
[GStreamer][WebRTC] Changing codec preferences on a transceiver can lead to
invalid SDP fmtp parameters in SDP
https://bugs.webkit.org/show_bug.cgi?id=280266
Reviewed by Xabier Rodriguez-Calvar.
In 252497@main support for VP9 profile2 was added, by keeping track of the fmtp
parameters in the
transceiver codec preferences, using codec-prefixed fields, which were then
read by the outgoing
video source at the moment of configuring the encoder. The issue is that those
fields with custom
prefix can end-up in SDP offers, and they're not spec compliant. So don't use a
prefix for those.
*
Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp:
(WebCore::toRtpCodecCapability):
*
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType):
Canonical link: https://commits.webkit.org/284212@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
