Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 41fb212daa290d014729a7005b3de77f30454657
https://github.com/WebKit/WebKit/commit/41fb212daa290d014729a7005b3de77f30454657
Author: Patrick Griffis <pgrif...@igalia.com>
Date: 2024-09-24 (Tue, 24 Sep 2024)
Changed paths:
M Source/WebCore/PlatformGTK.cmake
M Source/WebCore/PlatformWPE.cmake
M Source/WebCore/platform/SourcesGLib.txt
M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp
M Source/WebCore/platform/adwaita/ThemeAdwaita.cpp
M Source/WebCore/platform/adwaita/ThemeAdwaita.h
A Source/WebCore/platform/glib/SystemSettings.cpp
A Source/WebCore/platform/glib/SystemSettings.h
M Source/WebCore/platform/graphics/gtk/SystemFontDatabaseGTK.cpp
M Source/WebCore/platform/gtk/GtkUtilities.cpp
M Source/WebCore/platform/gtk/PlatformScreenGtk.cpp
M Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp
M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp
M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.h
M Source/WebKit/PlatformGTK.cmake
M Source/WebKit/PlatformWPE.cmake
M Source/WebKit/Shared/WebProcessCreationParameters.h
M Source/WebKit/Shared/WebProcessCreationParameters.serialization.in
A Source/WebKit/Shared/glib/SystemSettings.serialization.in
M Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in
R Source/WebKit/Shared/gtk/GtkSettingsState.h
M Source/WebKit/SourcesGTK.txt
M Source/WebKit/SourcesWPE.txt
M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
A Source/WebKit/UIProcess/glib/SystemSettingsManager.cpp
A Source/WebKit/UIProcess/glib/SystemSettingsManager.h
M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
M Source/WebKit/UIProcess/gtk/Display.cpp
R Source/WebKit/UIProcess/gtk/GtkSettingsManager.cpp
R Source/WebKit/UIProcess/gtk/GtkSettingsManager.h
M Source/WebKit/UIProcess/gtk/ScreenManagerGtk.cpp
A Source/WebKit/UIProcess/gtk/SystemSettingsManagerGtk.cpp
A Source/WebKit/WebProcess/glib/SystemSettingsProxy.cpp
A Source/WebKit/WebProcess/glib/SystemSettingsProxy.h
A Source/WebKit/WebProcess/glib/SystemSettingsProxy.messages.in
M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp
R Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.cpp
R Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.h
R Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.messages.in
Log Message:
-----------
[GLib] Replace GtkSettings usage with port agnostic settings
https://bugs.webkit.org/show_bug.cgi?id=278875
Reviewed by Carlos Garcia Campos.
This exposes settings as a singleton in WebCore that both
GTK and WPE can use.
For the GTK port it still reads GtkSettings to set all
of the values.
WPE doesn't expose an API to set these yet and just
returns default values.
* Source/WebCore/PlatformGTK.cmake:
* Source/WebCore/PlatformWPE.cmake:
* Source/WebCore/platform/SourcesGLib.txt:
* Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp:
(WebCore::ScrollbarThemeAdwaita::usesOverlayScrollbars const):
(WebCore::ScrollbarThemeAdwaita::handleMousePressEvent):
* Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:
(WebCore::ThemeAdwaita::ThemeAdwaita):
(WebCore::ThemeAdwaita::refreshSettings):
(WebCore::ThemeAdwaita::refreshGtkSettings): Deleted.
* Source/WebCore/platform/adwaita/ThemeAdwaita.h:
* Source/WebCore/platform/glib/SystemSettings.cpp: Added.
(WebCore::SystemSettings::singleton):
(WebCore::SystemSettings::updateSettings):
(WebCore::SystemSettings::hintStyle const):
(WebCore::SystemSettings::subpixelOrder const):
(WebCore::SystemSettings::antialiasMode const):
(WebCore::SystemSettings::addObserver):
(WebCore::SystemSettings::removeObserver):
* Source/WebCore/platform/glib/SystemSettings.h: Copied from
Source/WebKit/Shared/gtk/GtkSettingsState.h.
(WebCore::SystemSettings::settingsState const):
(WebCore::SystemSettings::themeName const):
(WebCore::SystemSettings::darkMode const):
(WebCore::SystemSettings::fontName const):
(WebCore::SystemSettings::cursorBlink const):
(WebCore::SystemSettings::cursorBlinkTime const):
(WebCore::SystemSettings::xftDPI const):
(WebCore::SystemSettings::overlayScrolling const):
(WebCore::SystemSettings::primaryButtonWarpsSlider const):
(WebCore::SystemSettings::enableAnimations const):
* Source/WebCore/platform/graphics/gtk/SystemFontDatabaseGTK.cpp:
(WebCore::SystemFontDatabase::platformSystemFontShorthandInfo):
* Source/WebCore/platform/gtk/GtkUtilities.cpp:
(WebCore::defaultGtkSystemFont):
(WebCore::shouldUseOverlayScrollbars):
* Source/WebCore/platform/gtk/PlatformScreenGtk.cpp:
(WebCore::fontDPI):
* Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
(WebCore::ScrollbarThemeGtk::handleMousePressEvent):
(WebCore::themeChangedCallback): Deleted.
* Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp:
(WebCore::RenderThemeAdwaita::caretBlinkInterval const):
* Source/WebCore/rendering/adwaita/RenderThemeAdwaita.h:
* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/PlatformWPE.cmake:
* Source/WebKit/Shared/WebProcessCreationParameters.h:
* Source/WebKit/Shared/WebProcessCreationParameters.serialization.in:
* Source/WebKit/Shared/glib/SystemSettings.serialization.in: Copied from
Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in.
* Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in:
* Source/WebKit/SourcesGTK.txt:
* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::effectiveAppearanceIsDark const):
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDispose):
(webkitWebViewBaseConstructed):
(webkitWebViewBaseCreateWebPage):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
* Source/WebKit/UIProcess/glib/SystemSettingsManager.cpp: Added.
(WebKit::SystemSettingsManager::themeName const):
(WebKit::SystemSettingsManager::darkMode const):
(WebKit::SystemSettingsManager::fontName const):
(WebKit::SystemSettingsManager::xftAntialias const):
(WebKit::SystemSettingsManager::xftHinting const):
(WebKit::SystemSettingsManager::xftHintStyle const):
(WebKit::SystemSettingsManager::xftRGBA const):
(WebKit::SystemSettingsManager::xftDPI const):
(WebKit::SystemSettingsManager::cursorBlink const):
(WebKit::SystemSettingsManager::cursorBlinkTime const):
(WebKit::SystemSettingsManager::primaryButtonWarpsSlider const):
(WebKit::SystemSettingsManager::overlayScrolling const):
(WebKit::SystemSettingsManager::enableAnimations const):
(WebKit::SystemSettingsManager::initialize):
(WebKit::SystemSettingsManager::settingsDidChange):
* Source/WebKit/UIProcess/glib/SystemSettingsManager.h: Renamed from
Source/WebKit/UIProcess/gtk/GtkSettingsManager.h.
* Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* Source/WebKit/UIProcess/gtk/Display.cpp:
(WebKit::Display::Display):
* Source/WebKit/UIProcess/gtk/ScreenManagerGtk.cpp:
* Source/WebKit/UIProcess/gtk/SystemSettingsManagerGtk.cpp: Renamed from
Source/WebKit/UIProcess/gtk/GtkSettingsManager.cpp.
(WebKit::SystemSettingsManager::themeName const):
(WebKit::SystemSettingsManager::darkMode const):
(WebKit::SystemSettingsManager::fontName const):
(WebKit::SystemSettingsManager::xftAntialias const):
(WebKit::SystemSettingsManager::xftHinting const):
(WebKit::SystemSettingsManager::xftHintStyle const):
(WebKit::SystemSettingsManager::xftRGBA const):
(WebKit::SystemSettingsManager::xftDPI const):
(WebKit::SystemSettingsManager::cursorBlink const):
(WebKit::SystemSettingsManager::cursorBlinkTime const):
(WebKit::SystemSettingsManager::primaryButtonWarpsSlider const):
(WebKit::SystemSettingsManager::overlayScrolling const):
(WebKit::SystemSettingsManager::enableAnimations const):
(WebKit::SystemSettingsManager::SystemSettingsManager):
* Source/WebKit/WebProcess/glib/SystemSettingsProxy.cpp: Renamed from
Source/WebKit/Shared/gtk/GtkSettingsState.h.
(WebKit::SystemSettingsProxy::initialize):
(WebKit::SystemSettingsProxy::SystemSettingsProxy):
(WebKit::SystemSettingsProxy::didChange):
* Source/WebKit/WebProcess/glib/SystemSettingsProxy.h: Renamed from
Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.h.
* Source/WebKit/WebProcess/glib/SystemSettingsProxy.messages.in: Renamed from
Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.messages.in.
* Source/WebKit/WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):
* Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.cpp: Removed.
Canonical link: https://commits.webkit.org/284171@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
