Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d0028eb9238051f7b21ff8ead6d69172ac84b791
https://github.com/WebKit/WebKit/commit/d0028eb9238051f7b21ff8ead6d69172ac84b791
Author: Dan Hecht <[email protected]>
Date: 2024-09-13 (Fri, 13 Sep 2024)
Changed paths:
M Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp
M Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h
M Source/JavaScriptCore/runtime/ObjectPropertyChangeAdaptiveWatchpoint.h
M Source/JavaScriptCore/runtime/StructureRareData.cpp
Log Message:
-----------
[JSC] Revert isValid() part of 283640@main
https://bugs.webkit.org/show_bug.cgi?id=279703
rdar://135985375
Reviewed by Mark Lam.
Turns out the isValid() methods aren't dead code. The base class
of these things that are not actually Watchpoints declares it
and provides an implementation that needs to be overriden by these
classes.
The bug was caught by running jsc stress tests on a "testing" build.
The test case I encountered did not reproduce on a standard Debug build.
* Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::isValid const):
* Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h:
* Source/JavaScriptCore/runtime/ObjectPropertyChangeAdaptiveWatchpoint.h:
* Source/JavaScriptCore/runtime/StructureRareData.cpp:
(JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::isValid
const):
Canonical link: https://commits.webkit.org/283664@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
