Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 309ad080eabf8d973e9674a4c42fc5b55f5c7ea3
      
https://github.com/WebKit/WebKit/commit/309ad080eabf8d973e9674a4c42fc5b55f5c7ea3
  Author: Xabier Rodriguez-Calvar <calva...@igalia.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp
    M Source/WebCore/platform/gstreamer/GStreamerQuirkRialto.cpp

  Log Message:
  -----------
  [GStreamer][webaudio] Rialto with WebKit audio sink
https://bugs.webkit.org/show_bug.cgi?id=278911

Reviewed by Philippe Normand.

Rialto supports single instance of webaudio pcm sing so it is not possible to 
create more than one WebAudio context. Use
WebKit audio sink instead, that mixes all webaudio contextes into single stream 
and pass it to rialto webaudio sink.

With webkit 2.38 webaudio src element produce 'non-interleaved' audio format 
that is not fully supported by some
platform sinks (audio output is breaking). WebKit audio sink (mixer pipeline) 
also doesn't seem to handle that
correctly. Mixer pipeline fails to negotiate caps and inter audio sink reqires 
the latest gst version to work with such
stream.

Patch by Andrzej Surdej <andrzej_sur...@comcast.com>.

* Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
* Source/WebCore/platform/gstreamer/GStreamerQuirkRialto.cpp:
(WebCore::GStreamerQuirkRialto::createWebAudioSink):

Canonical link: https://commits.webkit.org/283137@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to