Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4746d781a82c45804c89d324d580e5d6e5ceb6bd
https://github.com/WebKit/WebKit/commit/4746d781a82c45804c89d324d580e5d6e5ceb6bd
Author: Ben Nham <n...@apple.com>
Date: 2024-09-03 (Tue, 03 Sep 2024)
Changed paths:
M Source/WebKit/Platform/IPC/cocoa/DaemonConnectionCocoa.mm
Log Message:
-----------
Fix NetworkProcess crash when Notification.close() is called early in
notificationclick event handler
https://bugs.webkit.org/show_bug.cgi?id=279093
rdar://135232262
Reviewed by Sihui Liu.
When built-in notifications are enabled, if Notification.close() is called
early on before any other
IPC to webpushd, then it causes a NetworkProcess crash. The reason for this is
a long standing bug
in `Connection::send` in which we don't initialize the XPC connection before
sending the
message. This causes an abort in libxpc when trying to send a message to a null
connection.
* Source/WebKit/Platform/IPC/cocoa/DaemonConnectionCocoa.mm:
(WebKit::Daemon::Connection::send const):
Canonical link: https://commits.webkit.org/283133@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
