Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4a952c137807148a4bb342f1ae4d0ac6414e3446
https://github.com/WebKit/WebKit/commit/4a952c137807148a4bb342f1ae4d0ac6414e3446
Author: Jer Noble <jer.no...@apple.com>
Date: 2024-08-27 (Tue, 27 Aug 2024)
Changed paths:
A LayoutTests/media/av1-codec-validate-configuration-record-expected.txt
A LayoutTests/media/av1-codec-validate-configuration-record.html
M Source/WebCore/platform/graphics/AV1Utilities.cpp
M Source/WebCore/platform/graphics/AV1Utilities.h
M Source/WebCore/platform/graphics/cocoa/AV1UtilitiesCocoa.mm
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
Log Message:
-----------
[Cocoa] AV1 codec strings specifying 4:2:0 Colocated subsampling incorrectly
fail
https://bugs.webkit.org/show_bug.cgi?id=278676
rdar://134375956
Reviewed by Eric Carlson.
Correct a mismatch between CoreMedia's definition of the ChromaSubsampling
parameter
and the definition used by the AV1 ISO-BMFF bindings specification. CoreMedia
uses
a definition whose low-order digit specifies monochrome support, and AV1 uses
chroma
sample position in that same digit.
Construct a query paratemer which matches CoreMedia's definition from the codecs
string provided. Also, do more validation of combinations of monochrome and
subsampling
coordinates.
* LayoutTests/media/av1-codec-validate-configuration-record-expected.txt: Added.
* LayoutTests/media/av1-codec-validate-configuration-record.html: Added.
* Source/WebCore/platform/graphics/AV1Utilities.cpp:
(WebCore::validateAV1ConfigurationRecord):
* Source/WebCore/platform/graphics/AV1Utilities.h:
* Source/WebCore/platform/graphics/cocoa/AV1UtilitiesCocoa.mm:
(WebCore::validateAV1Parameters):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::validateAV1ConfigurationRecord):
Canonical link: https://commits.webkit.org/282806@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
