Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3357b1f7da58d86da53df06eb36f75c858ebe1b0 https://github.com/WebKit/WebKit/commit/3357b1f7da58d86da53df06eb36f75c858ebe1b0 Author: Per Arne Vollan <pvol...@apple.com> Date: 2024-08-21 (Wed, 21 Aug 2024)
Changed paths: M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm M Source/WebKit/Shared/WebProcessCreationParameters.h M Source/WebKit/Shared/WebProcessCreationParameters.serialization.in M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h Log Message: ----------- Assert Lockdown Mode flag has been set before queried https://bugs.webkit.org/show_bug.cgi?id=278128 rdar://133884110 Reviewed by Chris Dumez. Assert that Lockdown Mode flag has been set before queried in the WebContent process. This patch also initializes the Lockdown Mode flag in WebProcess earlier by using the value from the XPC initialization message, which is sent in the XPC extra initialization data. This patch also asserts that JSC options are set before JSC::initialize() is called. Setting JSC options after this call can lead to crashes. * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h: (WebKit::XPCServiceInitializer): * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm: (WebKit::XPCServiceInitializerDelegate::getExtraInitializationData): (WebKit::setJSCOptions): * Source/WebKit/Shared/WebProcessCreationParameters.h: * Source/WebKit/Shared/WebProcessCreationParameters.serialization.in: * Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: (WebKit::ProcessLauncher::finishLaunchingProcess): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::initializeNewWebProcess): * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getLaunchOptions): * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeProcess): (WebKit::WebProcess::initializeWebProcess): * Source/WebKit/WebProcess/WebProcess.h: (WebKit::WebProcess::isLockdownModeEnabled const): Canonical link: https://commits.webkit.org/282562@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes