Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d3d1407655456554f0f3421198bc0b67f90a02ad https://github.com/WebKit/WebKit/commit/d3d1407655456554f0f3421198bc0b67f90a02ad Author: Abrar Rahman Protyasha <a_protya...@apple.com> Date: 2024-08-14 (Wed, 14 Aug 2024)
Changed paths: M Source/WebCore/dom/PointerEvent.cpp M Source/WebCore/dom/PointerEvent.h M Source/WebCore/dom/ios/PointerEventIOS.cpp Log Message: ----------- PointerEvent and PointerEventIOS should share tilt-to-spherical angle conversion code https://bugs.webkit.org/show_bug.cgi?id=278095 rdar://133829451 Reviewed by Tim Horton. Following 282017@main, there were two code snippets that performed the same spherical-to-tilt angle conversion, one in PointerEvent.cpp and the other in PointerEventIOS.cpp. This patch fixes said duplication by exposing tilt-to-spherical (and vice versa) conversion methods as private static methods in the PointerEvent class. * Source/WebCore/dom/PointerEvent.cpp: (WebCore::PointerEvent::angleFromTilt): (WebCore::PointerEvent::tiltFromAngle): (WebCore::angleFromTilt): Deleted. (WebCore::tiltFromAngle): Deleted. * Source/WebCore/dom/PointerEvent.h: * Source/WebCore/dom/ios/PointerEventIOS.cpp: (WebCore::m_predictedEvents): Canonical link: https://commits.webkit.org/282255@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes