Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 56f5e3f163b718887889ad70381ddbad068bcaf7
https://github.com/WebKit/WebKit/commit/56f5e3f163b718887889ad70381ddbad068bcaf7
Author: Daniel Liu <danl...@umich.edu>
Date: 2024-08-14 (Wed, 14 Aug 2024)
Changed paths:
M Source/JavaScriptCore/wasm/WasmOpcodeOrigin.h
Log Message:
-----------
Fix incorrect parenthesization of OpcodeOrigin assertion
https://bugs.webkit.org/show_bug.cgi?id=278115
rdar://133845872
Reviewed by Yusuke Suzuki, Keith Miller and Mark Lam.
The issue arises from 281900@main, which updated
```
(opcode & (1 << 24) - 1) == opcode
```
to
```
((opcode & (1 << 24)) - 1) == opcode
```
However, this changes the semantics, since `-` binds tighter
than `&`, meaning that the new code would end up calculating
either `-1` or `(1 << 24) - 1` for every case, regardless of
what the opcode is, and likely causing an error.
* Source/JavaScriptCore/wasm/WasmOpcodeOrigin.h:
(JSC::Wasm::OpcodeOrigin::OpcodeOrigin):
Canonical link: https://commits.webkit.org/282247@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
