Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d13948d3347b05562a92cc1a91235f3767c85af8
https://github.com/WebKit/WebKit/commit/d13948d3347b05562a92cc1a91235f3767c85af8
Author: Brianna Fan <bf...@apple.com>
Date: 2024-08-08 (Thu, 08 Aug 2024)
Changed paths:
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
merge-queue blocks "unreviewed" PRs if r+ received from a user that isn't a
reviewer
https://bugs.webkit.org/show_bug.cgi?id=277038
rdar://132435062
Reviewed by Aakash Jain.
Ignore invalid reviewers in ValidateCommitterAndReviewer. They will be caught
in ValidateCommitMessage.
This allows for invalid reviews on commits that don't need reviews and if a
valid reviewer is
only written in the commit message.
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps): Fix typos.
* Tools/CISupport/ews-build/steps.py:
(ValidateChange.validate_github): Fix typo.
(ValidateCommitterAndReviewer): Ignore invalid reviewer. Set
'invalid_reviewers' and 'valid_reviewers'.
(ValidateCommitterAndReviewer.run):
(ValidateCommitMessage.run): Make summary more detailed.
(AddReviewerMixin.reviewers): Replace 'reviewers_full_names' with
'valid_reviewers'.
(AddReviewerToCommitMessage.doStepIf): Ditto.
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/282024@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
