Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ca202068171d6cced2d5a381eba85074fdabbdb https://github.com/WebKit/WebKit/commit/6ca202068171d6cced2d5a381eba85074fdabbdb Author: Philippe Normand <ph...@igalia.com> Date: 2024-07-30 (Tue, 30 Jul 2024)
Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.h M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp M Tools/Scripts/webkitpy/style/checkers/cpp.py M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp Log Message: ----------- [GStreamer] Implement gstStructureGetString() https://bugs.webkit.org/show_bug.cgi?id=277000 Reviewed by Xabier Rodriguez-Calvar. Usage of gst_structure_get_string() is no longer recommended. Use this new helper instead. This patch includes drive-by changes, reducing usage of raw pointers and avoiding memory allocations when possible (using StringView instead of GUniquePtr<char> in the GStreamerRtpTransceiverBackend). * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::requestPad): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp: (WebCore::toRtpCodecCapability): (WebCore::getMsidFromCurrentCodecPreferences): (WebCore::GStreamerRtpTransceiverBackend::setCodecPreferences): (): Deleted. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp: (WebCore::RTCStatsReport::Stats::Stats): (WebCore::RTCStatsReport::RtpStreamStats::RtpStreamStats): (WebCore::RTCStatsReport::CodecStats::CodecStats): (WebCore::RTCStatsReport::RemoteInboundRtpStreamStats::RemoteInboundRtpStreamStats): (WebCore::RTCStatsReport::RemoteOutboundRtpStreamStats::RemoteOutboundRtpStreamStats): (WebCore::RTCStatsReport::OutboundRtpStreamStats::OutboundRtpStreamStats): (WebCore::RTCStatsReport::TransportStats::TransportStats): (WebCore::iceCandidateType): (WebCore::RTCStatsReport::IceCandidateStats::IceCandidateStats): (WebCore::RTCStatsReport::IceCandidatePairStats::IceCandidatePairStats): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp: (WebCore::toRTCEncodingParameters): (WebCore::toRTCRtpSendParameters): (WebCore::payloadTypeForEncodingName): (WebCore::capsFromRtpCapabilities): (WebCore::capsFromSDPMedia): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.h: * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::gstStructureGet): * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h: * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::handleMessage): (WebCore::MediaPlayerPrivateGStreamer::loadNextLocation): * Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp: (transformCaps): (transformInPlace): * Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp: (WebCore::GStreamerMediaDescription::extractCodecName const): * Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp: (WebCore::GStreamerCaptureDeviceManager::addDevice): * Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp: (WebCore::GStreamerIncomingTrackProcessor::configure): (WebCore::GStreamerIncomingTrackProcessor::incomingTrackProcessor): * Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp: (WebCore::GStreamerVideoCapturer::reconfigure): * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp: (WebCore::RealtimeOutgoingAudioSourceGStreamer::setPayloadType): * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp: (WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType): * Tools/Scripts/webkitpy/style/checkers/cpp.py: (check_language): * Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest): * Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/281559@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes