Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed9c21817325fe7c6f0deadd7b7ed45a6cc4ae8a https://github.com/WebKit/WebKit/commit/ed9c21817325fe7c6f0deadd7b7ed45a6cc4ae8a Author: Sosuke Suzuki <aosuk...@gmail.com> Date: 2024-07-29 (Mon, 29 Jul 2024)
Changed paths: M Source/JavaScriptCore/runtime/StringPrototypeInlines.h Log Message: ----------- [JSC] Remove dead code for `String#replace` and `String#replaceAll` https://bugs.webkit.org/show_bug.cgi?id=276992 Reviewed by Ross Kirsling. We've added a fast path for `String#replace(string, string)` at https://commits.webkit.org/280990@main. With this addition, whenever the `replaceValue` in `stringReplaceUsingStringSearch` is a string, the fast path is executed. Therefore, the slow path is only reached when `replaceValue` is a function. This patch removes the code in the slow path of `stringReplaceUsingStringSearch` that considers `replaceValue` as a string, as it is dead code. * Source/JavaScriptCore/runtime/StringPrototypeInlines.h: (JSC::replaceUsingStringSearch): Canonical link: https://commits.webkit.org/281485@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes