Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8e0531623ae70d27cccd31e701361486df5bc198
https://github.com/WebKit/WebKit/commit/8e0531623ae70d27cccd31e701361486df5bc198
Author: Youenn Fablet <you...@apple.com>
Date: 2024-07-19 (Fri, 19 Jul 2024)
Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h
M
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.h
M
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.m
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/page/DeprecatedGlobalSettings.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.messages.in
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.h
Log Message:
-----------
Remove no longer needed WebRTC runtime preferences
https://bugs.webkit.org/show_bug.cgi?id=276774
rdar://132000721
Reviewed by Eric Carlson.
We remove WebRTCH264LowLatencyEncoderEnabled preference, which is only useful
on cocoa ports and on by default.
We remove WebRTCPlatformTCPSocketsEnabled and WebRTCPlatformUDPSocketsEnabled
preferences which are also unique to COCOA and on by default.
This allows to simplify a bit the code, in particular in NetworkRTCProvider
where we want to remove the use of libwebrtc socket server.
As a first step, we compile out in COCOA the use of libwebrtc packet socket
factory which is no longer needed given we use the nw API instead.
* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:
(webrtc::createWebKitEncoderFactory):
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h:
*
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.h:
*
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.m:
(-[RTCDefaultVideoEncoderFactory initWithH265:vp9Profile0:vp9Profile2:av1:]):
(-[RTCDefaultVideoEncoderFactory createEncoder:]):
(-[RTCDefaultVideoEncoderFactory
initWithH265:vp9Profile0:vp9Profile2:lowLatencyH264:av1:]): Deleted.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::webRTCH264LowLatencyEncoderEnabled):
Deleted.
(WebCore::DeprecatedGlobalSettings::setWebRTCH264LowLatencyEncoderEnabled):
Deleted.
(WebCore::DeprecatedGlobalSettings::webRTCPlatformTCPSocketsEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::setWebRTCPlatformTCPSocketsEnabled):
Deleted.
(WebCore::DeprecatedGlobalSettings::webRTCPlatformUDPSocketsEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::setWebRTCPlatformUDPSocketsEnabled):
Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
(WebCore::LibWebRTCProviderCocoa::createEncoderFactory):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::endSuspension): Deleted.
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processDidResume):
* Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::NetworkRTCProvider):
(WebKit::NetworkRTCProvider::createSocket):
(WebKit::NetworkRTCProvider::createUDPSocket):
(WebKit::NetworkRTCProvider::createClientTCPSocket):
(WebKit::NetworkRTCProvider::sendToSocket):
(WebKit::NetworkRTCProvider::closeSocket):
(WebKit::NetworkRTCProvider::setSocketOption):
(WebKit::NetworkRTCProvider::addSocket):
(WebKit::NetworkRTCProvider::takeSocket):
(WebKit::NetworkRTCProvider::callOnRTCNetworkThread):
(WebKit::NetworkRTCProvider::wrapNewTCPConnection): Deleted.
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h:
(WebKit::NetworkRTCProvider::authorizeListeningSockets): Deleted.
(WebKit::NetworkRTCProvider::setPlatformTCPSocketsEnabled): Deleted.
(WebKit::NetworkRTCProvider::setPlatformUDPSocketsEnabled): Deleted.
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.messages.in:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:
(WebKit::LibWebRTCSocketFactory::setConnection):
(WebKit::LibWebRTCSocketFactory::createNewConnectionSocket): Deleted.
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.h:
Canonical link: https://commits.webkit.org/281124@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
