Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62b6e2db547e1876be1a5e5e51676839fd58e46e
      
https://github.com/WebKit/WebKit/commit/62b6e2db547e1876be1a5e5e51676839fd58e46e
  Author: Keith Miller <keith_mil...@apple.com>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
    M Source/JavaScriptCore/jit/AssemblyHelpers.cpp
    M Source/JavaScriptCore/llint/InPlaceInterpreter.cpp
    M Source/JavaScriptCore/llint/LLIntData.h
    M Source/JavaScriptCore/parser/Nodes.h
    M Source/JavaScriptCore/runtime/JSCast.h
    M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/bio/connect.c
    M Source/WTF/wtf/cf/TypeCastsCF.h
    M Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/src/decode.c

  Log Message:
  -----------
  Fix build issues with latest Clang
https://bugs.webkit.org/show_bug.cgi?id=276198
rdar://130933637

Reviewed by Yusuke Suzuki.

The use of the template keyword to reference template members without a 
template argument list was deprecated in the C++ standard.
e.g. `foo.template bar()` nows needs to be `foo.template bar<>()`. I ran into a 
different issue with `std::reference_wrapper` that
blocked me from going any further, which AFAICT is a bug on the Clang side.

This also fixes a few other warnings that popped up while building with the new 
Clang denoted inline

* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): Clang didn't like the 
implicit static_cast<int32_t>(UINT32_MAX) so make it explicit with a 
static_assert no data was lost.
* Source/JavaScriptCore/jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitNonNullDecodeZeroExtendedStructureID): Clang didn't 
like the implicit static_cast<int32_t>(UINT32_MAX) so make it explicit with a 
static_assert no data was lost.
* Source/JavaScriptCore/llint/InPlaceInterpreter.cpp:
* Source/JavaScriptCore/llint/LLIntData.h:
(JSC::LLInt::getCodeFunctionPtr):
(JSC::LLInt::getWide16CodeFunctionPtr):
(JSC::LLInt::getWide32CodeFunctionPtr):
* Source/JavaScriptCore/parser/Nodes.h: Missing definition of ModuleScopeData 
added include.
* Source/JavaScriptCore/runtime/JSCast.h:
(JSC::JSCastingHelpers::inherits):
(JSC::jsDynamicCast):
* 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/bio/connect.c:
(conn_callback_ctrl): Had a warning about an incompatible function type. Seems 
like this is intentional suppressed the warning.
* Source/WTF/wtf/cf/TypeCastsCF.h: Had a warning about extra namespace 
qualification. I just moved it out of the namespace. That said, it feels like 
this warning shouldn't apply to macro expansions...
* Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/src/decode.c:
(decode_b): Had a warning about different types on the middle/right of a 
ternary expression. I just pushed the comparison inside the ternary.

Canonical link: https://commits.webkit.org/280700@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to