Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 968a81c0077cca90309f9aee9bab959597bd4f90
https://github.com/WebKit/WebKit/commit/968a81c0077cca90309f9aee9bab959597bd4f90
Author: Ryan Reno <rr...@apple.com>
Date: 2024-07-03 (Wed, 03 Jul 2024)
Changed paths:
A
LayoutTests/http/tests/geolocation/geolocation-get-current-position-does-not-leak.https-expected.txt
A
LayoutTests/http/tests/geolocation/geolocation-get-current-position-does-not-leak.https.html
A
LayoutTests/http/tests/geolocation/geolocation-watch-position-does-not-leak.https-expected.txt
A
LayoutTests/http/tests/geolocation/geolocation-watch-position-does-not-leak.https.html
A
LayoutTests/http/tests/geolocation/resources/geolocation-get-position-callback.html
A
LayoutTests/http/tests/geolocation/resources/geolocation-watch-position-callback.html
Log Message:
-----------
Add document leak tests for Geolocation callbacks
https://bugs.webkit.org/show_bug.cgi?id=276191
rdar://131057488
Reviewed by Ben Nham.
Add tests for navigator.geolocation callbacks to ensure they do not leak
Documents when capturing the document object.
Since the GC is conservative the test robustness is improved by creating
20 iframes and checking that at least one of them does not cause leaks.
It's possible that the GC sees something pointer-like to the Document
object and therefore keeps it alive. By spamming iframes we should be
able to convince it to collect at least one document, assuming it isn't
leaked via a reference cycle.
*
LayoutTests/http/tests/geolocation/geolocation-get-current-position-does-not-leak.https-expected.txt:
Added.
*
LayoutTests/http/tests/geolocation/geolocation-get-current-position-does-not-leak.https.html:
Added.
*
LayoutTests/http/tests/geolocation/geolocation-watch-position-does-not-leak.https-expected.txt:
Added.
*
LayoutTests/http/tests/geolocation/geolocation-watch-position-does-not-leak.https.html:
Added.
*
LayoutTests/http/tests/geolocation/resources/geolocation-get-position-callback.html:
Added.
*
LayoutTests/http/tests/geolocation/resources/geolocation-watch-position-callback.html:
Added.
Canonical link: https://commits.webkit.org/280650@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
