Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d36ed108e92fb350723da8e7a88e7a7e8be1ef45 https://github.com/WebKit/WebKit/commit/d36ed108e92fb350723da8e7a88e7a7e8be1ef45 Author: Xabier Rodriguez-Calvar <calva...@igalia.com> Date: 2024-06-11 (Tue, 11 Jun 2024)
Changed paths: A LayoutTests/media/media-source/media-source-seek-back-after-ended-expected.txt A LayoutTests/media/media-source/media-source-seek-back-after-ended.html M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp Log Message: ----------- [MSE][GStreamer] allow fallback to seeked position on seek finish https://bugs.webkit.org/show_bug.cgi?id=275104 Reviewed by Philippe Normand. MediaPlayerPrivateGStreamer may report incorrect position (last cached) immediately after seek. This can happen when didPreroll is called on async-done with pipeline still in async transition to playing state: current: PAUSED, pending: PLAYING, result: ASYNC. r277541 disables querying position from the sinks in this case resulting in last cached value (before seek) to be returned. Which confuses some tests from YouTube WV SFR/HFR suite, and makes it trigger multiple seeks one after another. The proposed change works around the problem by allowing fall back to last seeked position until pipeline preroll completes. Similar to MediaPlayerPrivateGStreamer::finishSeek(). Patch by Eugene Mutavchi <ievgen_mutav...@comcast.com>. * LayoutTests/media/media-source/media-source-seek-back-after-ended-expected.txt: Added. * LayoutTests/media/media-source/media-source-seek-back-after-ended.html: Added. * LayoutTests/platform/mac-wk1/TestExpectations: * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp: (WebCore::MediaPlayerPrivateGStreamerMSE::didPreroll): Canonical link: https://commits.webkit.org/279901@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes